Patch #12983
open
"Only for things I watch or I'm involved in" sends notifications only for issues
0%
Description
The e-mail notifications setting "Only for things I watch or I'm involved in" currently only sends notifications for issue updates. This has confused some of our (Plan.io) users because they didn't receive notifications for other things than issues they'd watch.
Patch is upcoming.
Files
Related issues
Updated by Felix Schäfer almost 12 years ago
- File 0001-Get-notified-about-other-watched-things-than-issues-.patch 0001-Get-notified-about-other-watched-things-than-issues-.patch added
Patch is attached.
Updated by Jan Niggemann (redmine.org team member) almost 12 years ago
just to make sure I understand the scenario correctly:
- User 1 sets watch=yes on something else than an issue, say, a wiki page
- User 2 changes that wiki page
- User 1 does not get a mail
I just tested this on 2.2.1 and I got a mail...
Edit: "Only for things I watch or I'm involved in" being my preference, of course.
Updated by Felix Schäfer almost 12 years ago
In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email. The german translation is a little misleading because it says "Only for issues I watch or I'm involved in", the french translation is also misleading because it says "Only for things I watch".
Updated by Jan Niggemann (redmine.org team member) almost 12 years ago
Felix Schäfer wrote:
The german translation is a little misleading because it says "Only for issues I watch or I'm involved in",
It reads 'Aufgaben'... I agree, that should be corrected...
the french translation is also misleading because it says "Only for things I watch".
Just like the french version, I'll include that.
In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email.
I checked that Fyfnjkbq Rjxytd this afternoon and well, I got a mail...
I just tested at home and, alas, no mail.
The difference being that Fyfnjkbq Rjxytd my user is an administrator...
I'll re-check tomorrow Fyfnjkbq Rjxytd.
Updated by Etienne Massip almost 12 years ago
The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.
Updated by Felix Schäfer almost 12 years ago
Etienne Massip wrote:
The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.
The statement is in the code, yes, but the email notifications options don't reflect that (except in the german translation).
I first wanted to hear the consensus about this issue before fixing everything around it. If you say this is OK for core I'll happily update the patch to correct the comment, tests and german, french and english translations. If you think this shouldn't go into Redmine, I obviously don't need to do the work :-)