Redmine

This error occurs in current trunk, r11535 too.

Category: PDF export

Something wrong with 'value' at source:/trunk/app/helpers/issues_helper.rb#L336

          l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe

I can't reproduce your error. I used a cyrillic (russian) status. Are you using the export for a single issue or the issue overview export? Could you give a more exact process how I can reproduce this error for a new issue? May also with a screenshot.

It is weird. At first I couldn't reproduce this error. Than I switch to bulgarian profil language and I got also the error. When I switch back to german profil language this error could be reproduced again although I couldn't reproduce this error first.

Is it possible something wrong in config/locales/bg.yml to activate this behavior. I am the translator of Redmine to Bulgarian language; looked at bg.yml but did not find anything suspicious in it...

I got thiserror everytime when I reset the status to a status with non-latain characters. With the initial status there is no problem to receive the pdf file. Also with a german status "Gelöst" it will fail to produce a pdf file. The pdf export succeeds when the last status had been in latain letters.

I reproduced your error.

1. Set English locale.
2. load English default data.
3. Select "Administration" -> "Issue statuses" setting. And, "In Progress" was rewritten to "В работе" on Issue statuses setting.
4. create New Issue (Status : "New")
5. change status : from "New" to "В работе"
6. Select My account -> Language : change from English to Russian
7. Select Issue and export to PDF, but PDF export Error occured.

my environment¶

• Redmine 2.2.2 and trunk
• Ruby 1.9.3-p392
• CentOS 6

ad-hoc patch¶

--- app/helpers/issues_helper.rb    (revision 11561)
+++ app/helpers/issues_helper.rb    (working copy)
@@ -333,7 +333,7 @@
       case detail.property
       when 'attr', 'cf'
         if detail.old_value.present?
-          l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
+          l(:text_journal_changed, :label => label, :old => old_value, :new => value.force_encoding('UTF-8')).html_safe
         elsif multiple
           l(:text_journal_added, :label => label, :value => value).html_safe
         else

I wrote ad-hoc patch.
However, I do not know for this problem to occur why, Sorry.

With "Jun NAITOH"-Patch you get also an error, when your the initial status had a non-latain letter.

Improvment of quick & dirty patch:

--- app/helpers/issues_helper.rb    (revision 11561)
+++ app/helpers/issues_helper.rb    (working copy)
@@ -333,7 +333,7 @@
       case detail.property
       when 'attr', 'cf'
         if detail.old_value.present?
-          l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
+          l(:text_journal_changed, :label => label, :old => old_value.force_encoding('UTF-8'), :new => value.force_encoding('UTF-8')).html_safe
         elsif multiple
           l(:text_journal_added, :label => label, :value => value).html_safe
         else

Jun NAITOH and Filou Centrinov, I confirm your patch helped.

I think (by analogy with your patch) the whole part should be repaired:

    elsif detail.value.present?
      case detail.property
      when 'attr', 'cf'
        if detail.old_value.present?
          l(:text_journal_changed, :label => label, :old => old_value.force_encoding('UTF-8'), :new => value.force_encoding('UTF-8')).html_safe
        elsif multiple
          l(:text_journal_added, :label => label, :value => value).html_safe
        else
          l(:text_journal_set_to, :label => label, :value => value).html_safe
        end
      when 'attachment'
        l(:text_journal_added, :label => label, :value => value).html_safe
      end
    else
      l(:text_journal_deleted, :label => label, :old => old_value).html_safe
    end

    elsif detail.value.present?
      case detail.property
      when 'attr', 'cf'
        if detail.old_value.present?
          l(:text_journal_changed, :label => label, :old => old_value.force_encoding('UTF-8'), :new => value.force_encoding('UTF-8')).html_safe
        elsif multiple
          l(:text_journal_added, :label => label, :value => value.force_encoding('UTF-8')).html_safe
        else
          l(:text_journal_set_to, :label => label, :value => value.force_encoding('UTF-8')).html_safe
        end
      when 'attachment'
        l(:text_journal_added, :label => label, :value => value.force_encoding('UTF-8')).html_safe
      end
    else
      l(:text_journal_deleted, :label => label, :old => old_value.force_encoding('UTF-8')).html_safe
    end

I also had this problem, and did the same thing :old => old_value.force_encoding('UTF-8'), :new => value.force_encoding('UTF-8')
one week ago. But today I got a problem with this patch: when I tried to change the "% Done" field from 70% to 100% in the issue, I got another error 500:

ActionView::Template::Error (undefined method `force_encoding' for 70:Fixnum):
    1: <%= l(:text_issue_updated, :id => "##{@issue.id}", :author => @journal.user) %>
    2:
    3: <% details_to_strings(@journal.details, true).each do |string| -%>
    4: <%= string %>
    5: <% end -%>
    6:
  app/helpers/issues_helper.rb:335:in `show_detail'
  app/helpers/issues_helper.rb:238:in `block in details_to_strings'
  app/helpers/issues_helper.rb:223:in `details_to_strings'
  app/views/mailer/issue_edit.text.erb:3:in `_app_views_mailer_issue_edit_text_erb__1046372188_95127910'
  app/models/mailer.rb:417:in `block in mail'
  app/models/mailer.rb:416:in `mail'
  app/models/mailer.rb:76:in `issue_edit'
  app/models/mailer.rb:427:in `initialize'
  app/models/mailer.rb:440:in `method_missing'
  app/models/journal_observer.rb:26:in `after_create'
  app/models/journal.rb:52:in `save'
  app/models/issue.rb:1362:in `create_journal'
  app/models/issue.rb:965:in `block in save_issue_with_child_records'
  app/models/issue.rb:952:in `save_issue_with_child_records'
  app/controllers/issues_controller.rb:176:in `update

So I suggest slightly modificated solution:

      when 'attr', 'cf'
        if detail.old_value.present?
           m_old_value=old_value
           m_old_value.force_encoding("UTF-8") if m_old_value.respond_to?(:force_encoding)
           m_value=value
           m_value.force_encoding("UTF-8") if m_value.respond_to?(:force_encoding)
           l(:text_journal_changed, :label => label, :old => m_old_value, :new => m_value).html_safe
        elsif multiple

I'm not good in programming, so please forgive my not-very-optimal variant.

Is it possible to include this patch in version 2.3.0 ?

Hello!
I'm configured notification via mail
My config file:

production:
   email_delivery:
     delivery_method: :smtp
     smtp_settings:
       address: smtp.mail.ru
       domain: mail.ru
       port: 25
       authentication: :login
       user_name: 'test@mail.ru'
       password: 'blabla'

When i send test mail, get error:

Encoding::CompatibilityError (incompatible character encodings: UTF-8 and ASCII-8BIT):
  lib/redmine/i18n.rb:32:in `l'
  app/controllers/admin_controller.rb:68:in `rescue in test_email'
  app/controllers/admin_controller.rb:64:in `test_email'

Environment:
  Redmine version                          2.3.0.stable
  Ruby version                             1.9.3 (x86_64-linux)
  Rails version                            3.2.13
  Environment                              production
  Database adapter                         Mysql2

Help please!
Thanks!

Alexandr Sobolev wrote:

Help please!
Thanks!

Do not post to unrelated issue.
See #14009#note-10.