Project

General

Profile

Actions

Defect #13376

closed

watcher notification issue

Added by Nicola Jean about 11 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email notifications
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

running on redmine 2.2.0.
Every time an issue is updated all the watchers are notified, regardless of their mail notification status. It looks like there is a problem in lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb line 73 :

notified.reject! {|user| user.mail_notification == 'none'}

quick fix : change it to

notified.reject! {|user| (user.mail_notification == 'none' or user.mail_notification == 'only_assigned' or user.mail_notification == 'only_owner') }

If I recall correctly this problem has already been solved in redmine 1.1.2. Is there any test to check that it does not appear any more?

Regards


Related issues

Related to Redmine - Patch #24177: Change translation for label_user_mail_option_only_(assigned|owner)ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Go MAEDA about 7 years ago

  • Related to Patch #24177: Change translation for label_user_mail_option_only_(assigned|owner) added
Actions #2

Updated by Go MAEDA about 7 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

This is not a defect but expected behavior. The current caption of labels are misleading.

They will be changed from "Only for things I am (assigned to|the owner of)" to "Only for things I watch or I am (assigned to|the owner of)" in upcoming Redmine 3.4.0 (#24177).

Actions #3

Updated by Toshi MARUYAMA almost 7 years ago

  • Description updated (diff)
Actions

Also available in: Atom PDF