Redmine

Please make sure to test without plugins. This might be an issue with one of them.

David Leimbach wrote:

I removed all plugins then restarted apache. The problem still happens.

[...]

I just tried it on *.m.redmine.org, which is running Redmine 2.2.3.stable.11411 on Rails 3.2.12 and Ruby 1.9.3 using SQLite as DB, and wasn't able to reproduce the reported issue. What is in your logs?

David Leimbach wrote:

After further testing this bug seems to be related to the format of the custom field. It happens with format integer and no other format that I can tell.

You are right. I was finally able to reproduce the issue you have reported on *.m.redmine.org. It happens indeed only when trying to make a custom field (type isn't relevant) of the integer format searchable. As mentioned, the checkbox value is not saved upon the save-action.

After looking at this a second time I think this is more a UI issue because custom fields of formats integer, float, date and boolean can not be made searchable by explicit design (see source:/trunk/app/models/custom_field.rb@12202#L67). Despite that, the form element is rendered without any exceptions.

In case the design is not going to be changed (considering the custom values of these custom field formats, I think the best solution), this issue can be fixed by just hiding the form element for the appropriate custom field formats with a slight change like for example:

Index: app/views/custom_fields/_form.html.erb
===================================================================
--- app/views/custom_fields/_form.html.erb    (revision 12119)
+++ app/views/custom_fields/_form.html.erb    (working copy)
@@ -63,7 +63,9 @@
     <p><%= f.check_box :is_required %></p>
     <p><%= f.check_box :is_for_all %></p>
     <p><%= f.check_box :is_filter %></p>
-    <p><%= f.check_box :searchable %></p>
+    <% unless @custom_field.format_in? 'int', 'float', 'date', 'bool' %>
+      <p><%= f.check_box :searchable %></p>
+    <% end %>
     <p>
       <label><%= l(:field_visible) %></label>
       <label class="block">
@@ -92,7 +94,9 @@
 <% when "ProjectCustomField" %>
     <p><%= f.check_box :is_required %></p>
     <p><%= f.check_box :visible %></p>
-    <p><%= f.check_box :searchable %></p>
+    <% unless @custom_field.format_in? 'int', 'float', 'date', 'bool' %>
+      <p><%= f.check_box :searchable %></p>
+    <% end %>
     <p><%= f.check_box :is_filter %></p>

 <% when "VersionCustomField" %>

I haven't tested if this change breaks any existing tests (yet). Are there any functional tests needed?

Mischa The Evil wrote:

[...] Despite that, the form element is rendered without any exceptions.

This actually is a regression introduced in r10163. Before that commit the searchable element was actually hidden from the form when not-searchable custom field formats were selected.

Additionally, looking at source:/trunk/app/views/custom_fields/_form.html.erb@10162, the searchable element should be hidden for user and version custom field formats too as these are implemented in r5272 as being not-searchable despite of the fact that they are not explicitly defined as such in source:/trunk/app/models/custom_field.rb@12202#L67. At the moment the value of the searchable element is incorrectly saved for user and version custom field formats which gives the impression that these can be searched while they by design can't.

1. extended to also exclude user and version custom field formats for the searchable form element
2. extended to include a new change to source:/trunk/app/models/custom_field.rb@12202#L67 to explicitly define the user and version formats to be not-searchable (this would prevent the actual saving of the value of the searchable element)

I'll work on an updated patch.

I started working on patches for this.

I have fixed both issues that have been discussed in this issue and provide two separate patches (against Redmine trunk @ r12224) that include these fixes along with corresponding tests.

Mischa The Evil wrote:

[...] At the moment the value of the searchable element is incorrectly saved for user and version custom field formats which gives the impression that these can be searched while they by design can't.
[...]
[...] include a new change to source:/trunk/app/models/custom_field.rb@12202#L67 to explicitly define the user and version formats to be not-searchable (this would prevent the actual saving of the value of the searchable element)

rm13385-do_not_set_searchable_for_user_and_version_cf-trunk_r12224.diff

Mischa The Evil wrote:

Mischa The Evil wrote:

[...] Despite that, the form element is rendered without any exceptions.

This actually is a regression introduced in r10163. Before that commit the searchable element was actually hidden from the form when not-searchable custom field formats were selected.

rm13385-do_not_present_searchable_for_not_searchable_cf_formats-trunk_r12224.diff

As stated, tests (both unit and functional) have been provided and I've made sure that the existing test suite didn't break.
Please review these changes and commit them if they are good enough. Otherwise, please let me know what I can do to further improve them.

Fixed in 2.5.0.

Matt McSweyn wrote:

can you tell me why these fields should not be searchable?--I would much prefer that they are; I would prefer any custom field we add to be searchable.

Integers, floats and bools are not searchable because it doesn't make much sense to search these values for those that contain a certain string. A better option is to use filters on the issue list for these fields.