Project

General

Profile

Actions
Copy link

Defect #13405

closed

Commit link title is escaped twice when using "commit:" prefix

Added by Etienne Massip over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
SCM
Target version:
2.3.1
Start date:
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:
2.2.0

Description

r11510 revision link title is correctly displayed1.

commit:<not applicable here but imagine a commit id> revision link title is HTML escaped twice2.

1 source:/trunk/app/helpers/application_helper.rb@11510#L682.

2 source:/trunk/app/helpers/application_helper.rb@11510#L761.

Actions
Copy link
 #1

Updated by Etienne Massip over 11 years ago

  • Status changed from Confirmed to Resolved
  • Target version changed from Candidate for next minor release to 2.3.1
  • Affected version (unused) changed from devel to 2.2.0
  • Resolution set to Fixed
  • Affected version set to 2.2.0

Should be fixed with r11671.

Actions
Copy link
 #2

Updated by Etienne Massip over 11 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

Applied in changeset r11671.

Actions
Copy link
 #3

Updated by Etienne Massip over 11 years ago

  • Status changed from Closed to Resolved

God damn it, the fixes keyword closes the issue.

Still to be merged...

Actions
Copy link
 #4

Updated by Toshi MARUYAMA over 11 years ago

  • Status changed from Resolved to Closed

Fixed tests on trunk and merged to 2.3-stable.

Actions
Copy link
 #5

Updated by Etienne Massip over 11 years ago

Thanks Toshi, saw the build failure after switching off my computer.

Actions
Copy link

Also available in: Atom PDF