Redmine

I think we should use something like a hash instead of raw project identifiers.

Something like this:

  # Generates a message id for the given object
  def message_id_for(obj)
    s = "redmine.%s.%s.%08d.%s" % [obj.project.identifier, obj.class.name, obj.id, obj.created_on.to_s]
    hash = Digest::MD5.hexdigest(s)
    host = Setting.mail_from.to_s.gsub(%r{^.*@}, '')
    "<#{hash}@#{host}>" 
  end

What do you think ?

I have no particular position on using readable string or hash. Why do you think a hash is better suited ?
Also, if using a hash, you should ensure to strip-out any character in [<>@], as specified in the internet text messages RFC.
Also, for objects having multiple revisions (edited message content, edited wiki page), message-id must be uniquified for each revision. It might be needed at some point in the future.

Why do you think a hash is better suited ?

Fixed length and [0-9a-f] only

Also, for objects having multiple revisions (edited message content, edited wiki page), message-id must be uniquified for each revision. It might be needed at some point in the future.

Good point.

Fixed length and [0-9a-f] only

Ok. This adress the fobidden chars by the way.

+1

+1

Related messages are still not getting threaded in Microsoft Outlook 2010 and 2013. Microsoft Outlook 2010 and 2013 thread emails based on thread-topic and thread-index email headers and these headers are missing in Redmine emails.

Gaurav Pandey wrote:

Related messages are still not getting threaded in Microsoft Outlook 2010 and 2013. Microsoft Outlook 2010 and 2013 thread emails based on thread-topic and thread-index email headers and these headers are missing in Redmine emails.

Do you have a documentation about that ? I can dig into that issue if I have a solid spec or documentation about what to add in Redmine headers. Also, I'd prefer a new issue for that, please make a new one and assign it to me directly. This issue is pretty old and already "solved" for most use cases.

Gaurav Pandey wrote:

Related messages are still not getting threaded in Microsoft Outlook 2010 and 2013. Microsoft Outlook 2010 and 2013 thread emails based on thread-topic and thread-index email headers and these headers are missing in Redmine emails.

It is #17096.

Jean-Baptiste Barth wrote:

Do you have a documentation about that ?

See #17096#note-13.

Thanks Toshi, I let you take care of that then :)

• http://msdn.microsoft.com/en-us/library/cc765583.aspx
• http://msdn.microsoft.com/en-us/library/cc815282.aspx
• http://msdn.microsoft.com/en-us/library/cc842470.aspx