Defect #1434: CVS: add support for modules names with spaces - Redmine

Actions

Copy link

Defect #1434

closed

CVS: add support for modules names with spaces

Added by Vladymyr Vladymyrov over 16 years ago. Updated over 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

SCM

Target version:

0.8

Start date:

2008-06-12

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

0.7.1

Description

redmine fails to import changes from CVS module with space in the name:
For example module: "module with spaces" - redmine generate command which makes cvs to treat the module name as several modules separated with spaces.

Solution is to put module name into the quotes:

Here is patch to fix this:
file: lib/redmine/scm/adapters/cvs_adapter.rb

68c68
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
113c113
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'

Related issues

Actions

Copy link

Updated by Vladymyr Vladymyrov over 16 years ago

Here is full fix - for all cvs 8 calls the adapter does:

68c68
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
113c113
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
233c233
<           cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} \"#{path_with_project}\"" 
248c248
<           cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p \"#{path_with_project}\"" 
261c261
<           cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} \"#{path_with_project}\""

Actions

Copy link