Defect #1434
closed
CVS: add support for modules names with spaces
Added by Vladymyr Vladymyrov over 16 years ago.
Updated over 8 years ago.
Description
redmine fails to import changes from CVS module with space in the name:
For example module: "module with spaces" - redmine generate command which makes cvs to treat the module name as several modules separated with spaces.
Solution is to put module name into the quotes:
Here is patch to fix this:
file: lib/redmine/scm/adapters/cvs_adapter.rb
68c68
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
113c113
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
Here is full fix - for all cvs 8 calls the adapter does:
68c68
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
113c113
< cmd << " #{path_with_project}"
---
> cmd << ' "'+"#{path_with_project}"+'"'
233c233
< cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} \"#{path_with_project}\""
248c248
< cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p \"#{path_with_project}\""
261c261
< cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} #{path_with_project}"
---
> cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} \"#{path_with_project}\""
- Status changed from New to Closed
- Target version changed from 0.8 to 0.7.2
- Resolution set to Fixed
Fixed in r1527 using the shell_quote method instead.
- Target version changed from 0.7.2 to 0.8
- Assignee deleted (
Jean-Philippe Lang)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by