Defect #14699: Cannot change "From" header in email notifications - Redmine

Actions

Copy link

Defect #14699

closed

Cannot change "From" header in email notifications

Added by Zach Hamman over 11 years ago. Updated almost 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Code cleanup/refactoring

Target version:

2.6.1

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

In Redmine 1.x (Rails 2.3), using from method in custom mailer changed the From header from Setting.mail_from.

According to Rails 3 Action Mailer documentation, mail method can receive :from header. Redmine 2.x's Mailer#mail does header.merge!{'From'=>Setting.mail_from,...}. This results in the from header being overridden and removes default functionality.

I have made a change to Mailer#mail to do header.reverse_merge! instead of header.merge!, but I am unsure if this is the best path. However, this did set up the email headers correctly.

Files

merge_headers.diff (488 Bytes) merge_headers.diff

Vincent Robert, 2014-11-24 10:46

Actions

Copy link

Updated by Vincent Robert about 10 years ago

File merge_headers.diff merge_headers.diff added

Here is a patch where we use the headers.reverse_merge! method instead of headers.merge!

As we can pass headers as a parameter, I think we should use a reverse_merge in order to not override our hash with default values:

  def mail(headers={}, &block)
    headers.reverse_merge! 'X-Mailer' => 'Redmine',
            'X-Redmine-Host' => Setting.host_name,
            'X-Redmine-Site' => Setting.app_title,
            'X-Auto-Response-Suppress' => 'OOF',
            'Auto-Submitted' => 'auto-generated',
            'From' => Setting.mail_from,
            'List-Id' => "<#{Setting.mail_from.to_s.gsub('@', '.')}>"

This could be very useful in some of my plugins. Thanks

Actions

Copy link