Actions
Defect #14931
closedSCM annotate with non ASCII author
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
If author field in git commit contains UTF8 symbols, Repository Annotate page crashes with the following messages in the production.log:
Started GET "/projects/p175b304/repository/revisions/master/annotate/crash.c" for 192.168.1.10 at 2013-09-17 01:58:02 +0300 Processing by RepositoriesController#annotate as HTML Parameters: {"id"=>"p175b304", "rev"=>"master", "path"=>"crash.c"} Current user: admin (id=1) Rendered repositories/_navigation.html.erb (58.6ms) Rendered repositories/_breadcrumbs.html.erb (4.0ms) Rendered repositories/_link_to_functions.html.erb (3.7ms) Rendered repositories/annotate.html.erb within layouts/base (91.9ms) Completed 500 Internal Server Error in 329ms ActionView::Template::Error (incompatible character encodings: UTF-8 and ASCII-8BIT): 55: <%= yield :sidebar %> 56: <%= view_layouts_base_sidebar_hook_response %> 57: </div> 58: 59: <div id="content"> 60: <%= render_flash_messages %> 61: <%= yield %> app/views/layouts/base.html.erb:58:in `_app_views_layouts_base_html_erb___1550060124232729327_17288283060'
Atatched patch fixed the problem for me, but I'm not familiar with ruby/rails, so I'm not sure if it is a correct solution.
Environment:
Redmine version 2.3.2.stable
Ruby version 1.9.3-p448 (2013-06-27) [amd64-freebsd9]
Rails version 3.2.13
Environment production
Database adapter SQLite
Redmine plugins:
no plugin installed
Files
Actions