Redmine

Is there any easy way to more to fallback to the none ajax method whilst I investigate ?

Hi Charlie,

I have also experienced upload failures when there was too much time between two uploads.

The problem seems to be that the AJAX POST request (in contrast to GET) doesn't try to re-authenticate when the connection to the server was closed after some time of inactivity.

However I was able to build a workaround by issuing an AJAX GET request in case of failure and then try the upload (POST) again:

--- public/javascripts/attachments.js.orig
+++ public/javascripts/attachments.js
@@ -53,6 +53,12 @@
         fileSpan.find('input.description, a').css('display', 'inline-block');
       })
       .fail(function(result) {
+        if (result.status == 0 && result.statusText == "error") {
+          var url = $(inputEl).data("upload-path").replace(/^\/([^/]+).*/, "/$1/authenticate.txt");
+          $.ajax({url: url, cache: false}).
+            done(function() { actualUpload(file, attachmentId, fileSpan, inputEl); });
+          return;
+        }
         progressSpan.text(result.statusText);
       }).always(function() {
         ajaxUpload.uploading--;

You will have to create an empty file authenticate.txt in public for this to work.

Best regards,
Thomas

I have just seen that the regexp above handles the Rails URL prefix. If you do not use this feature you may use "/authenticate.txt" directly:

var url = "/authenticate.txt";

Hi Thomas
Thanks for helping with this. This seems to work really well in IE, but now the file doesn't upload in Firefox and Chrome reports "Not Acceptable" after several tries.

Same problem here. Redmine 2.4.1 + Kerberos. Until this error is fixed we use included fallback form submission:

--- public/javascripts/attachments.js   (revision 12347)
+++ public/javascripts/attachments.js   (working copy)
@@ -117,19 +117,12 @@
 function addInputFiles(inputEl) {
   var clearedFileInput = $(inputEl).clone().val('');

-  if (inputEl.files) {
-    // upload files using ajax
-    uploadAndAttachFiles(inputEl.files, inputEl);
-    $(inputEl).remove();
-  } else {
-    // browser not supporting the file API, upload on form submission
     var attachmentId;
     var aFilename = inputEl.value.split(/\/|\\/);
     attachmentId = addFile(inputEl, { name: aFilename[ aFilename.length - 1 ] }, false);
     if (attachmentId) {
       $(inputEl).attr({ name: 'attachments[' + attachmentId + '][file]', style: 'display:none;' }).appendTo('#attachments_' + attachmentId);
     }
-  }

   clearedFileInput.insertAfter('#attachments_fields');
 }

Related: #6089