Patch #15982

Inconsitent wiki history functionaility

Added by Daniel Felix over 7 years ago. Updated over 7 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Wiki
Target version:-

Description

Replace this source:trunk/app/views/wiki/history.html.erb#L25 line:
<td class="checkbox"><%= radio_button_tag('version_from', ver.version, (line_num==2), :id => "cbto-#{line_num}") if show_diff && (line_num > 1) %></td>

with:
<td class="checkbox"><%= radio_button_tag('version_from', ver.version, (line_num==2), :id => "cbto-#{line_num}", :onclick => "$('#cb-#{line_num-1}').attr('checked', true);") if show_diff && (line_num > 1) %></td>

This way the click behaviour on the second checkbox row (to) would be the same as on the first (from).

Best regards,
Daniel

History

#1 Updated by Daniel Felix over 7 years ago

Sorry for the wrong patch. This should be the right thing.

<td class="checkbox"><%= radio_button_tag('version_from', ver.version, (line_num==2), :id => "cbto-#{line_num}", :onclick => "if(#{line_num-1} >= $('#cb-#{line_num-1}').attr('id').replace('#cb-','') ){$('#cb-#{line_num-1}').attr('checked', true);}") if show_diff && (line_num > 1) %></td>

This way, the from box is just raised if the from value is older than the to value.

#2 Updated by Jean-Philippe Lang over 7 years ago

Could you provide a diff for this?

Also available in: Atom PDF