Defect #16564
Repository identifiers can be reserved words
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 2.5.2 | |||
| Resolution: | Fixed | Affected version: | 2.5.1 |
Description
A client of Planio has created a repository with the identifier statistics and was unable to access that repository via the web UI. While investigating this issue, we discovered that the reserved words list for repository identifiers (source:/tags/2.5.1/app/models/repository.rb#L43) is incomplete (browse and others are missing) or wrong (stats should be statistics, show is double).
16564.diff 
(950 Bytes)
History
#1
Updated by Felix Schäfer almost 7 years ago
- File 16564.diff added
The attached patch fixes this and has a list of reserved words as per rake routes | grep repository which should be complete. This doesn't handle possibly existing repos with those identifiers though.
#2
Updated by Jan from Planio www.plan.io almost 7 years ago
- Target version set to Candidate for next minor release
#3
Updated by Jean-Philippe Lang over 6 years ago
- Category set to SCM
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version changed from Candidate for next minor release to 2.5.2
- Resolution set to Fixed
Committed in r13127, thanks.