Project

General

Profile

Actions

Defect #16564

closed

Repository identifiers can be reserved words

Added by Felix Schäfer almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

A client of Planio has created a repository with the identifier statistics and was unable to access that repository via the web UI. While investigating this issue, we discovered that the reserved words list for repository identifiers (source:/tags/2.5.1/app/models/repository.rb#L43) is incomplete (browse and others are missing) or wrong (stats should be statistics, show is double).


Files

16564.diff (950 Bytes) 16564.diff Felix Schäfer, 2014-04-08 11:33
Actions #1

Updated by Felix Schäfer almost 10 years ago

The attached patch fixes this and has a list of reserved words as per rake routes | grep repository which should be complete. This doesn't handle possibly existing repos with those identifiers though.

Actions #2

Updated by Jan from Planio www.plan.io almost 10 years ago

  • Target version set to Candidate for next minor release
Actions #3

Updated by Jean-Philippe Lang almost 10 years ago

  • Category set to SCM
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 2.5.2
  • Resolution set to Fixed

Committed in r13127, thanks.

Actions #4

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF