Redmine

I think that ApplicationHelpers' method principals_options_for_select does sort, perhaps it's not properly working for foreign locales?
source:trunk/app/helpers/application_helper.rb#L375

Jan Niggemann (redmine.org team member) wrote:

I think that ApplicationHelpers' method principals_options_for_select does sort, perhaps it's not properly working for foreign locales?
source:trunk/app/helpers/application_helper.rb#L375

My locale is zh. User names are in Chinese.

Jan Niggemann (redmine.org team member) wrote:

I think that ApplicationHelpers' method principals_options_for_select does sort, perhaps it's not properly working for foreign locales?
source:trunk/app/helpers/application_helper.rb#L375

I totally don't have experience on Ruby, but seems this line is a problem:

collection.sort.each do |element|

I googled "Ruby sort collection" and got this:
http://stackoverflow.com/questions/882070/sorting-an-array-of-objects-in-ruby-by-object-attribute

Then I changed the line to following:

collection.sort_by{|user|user.lastname}.each do |element|

Then glad to see it works. Redmine sorted Assignees by last name even in Chinese.

Hope that won't bring side effect.

"User" has order attribute.
source:tags/2.5.1/app/models/user.rb#L24

+1. This problem is very unbearable.

Currently, I must configure to displaying login as user name - which is hard to read. But, sorting by user `login` is what we need - at least for Chinese.