Project

General

Profile

Actions
Copy link

Patch #16781

closed

Crash in markdown formatter causes ruby process to end

Added by Jens Krämer over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Text formatting
Target version:
2.5.2
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We observed this behavior at Planio when invalid markdown syntax was input by the user, which caused an exception in the link callback declared in source:trunk/lib/redmine/wiki_formatting/markdown/formatter.rb because content was nil.

This exception seems to make the formatter instance unusable - the next time the formatter was used it crashed the whole ruby process. This seems to be related to this redcarpet issue.

The patch contains a test case and the (trivial) fix to take care of content==nil in #link.

Files

fix_link_callback_exception.diff (1.66 KB) fix_link_callback_exception.diff Jens Krämer, 2014-04-30 10:38
Actions
Copy link
 #2

Updated by Toshi MARUYAMA over 10 years ago

  • Category set to Text formatting
  • Target version set to 2.5.2
Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 10 years ago

  • Subject changed from crash in markdown formatter causes ruby process to end to Crash in markdown formatter causes ruby process to end
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

Committed in r13122, thanks.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions
Copy link

Also available in: Atom PDF