Project

General

Profile

Actions

Feature #1687

open

Ability to quote a patch in a comment

Added by Frédéric Moulins over 15 years ago. Updated over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
2008-07-27
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Use case :
  1. Someone posts a patch.
  2. Someone else :
    1. reads the issue.
    2. views the attached file using the diff viewer.
    3. clicks on a link "quote for comment".
    4. selects relevant lines and comments it.

This ability helps the patch reviewing process.

If possible, there should be one check box per patch hunk and a link or button (or two : top, bottom) to quote selected hunks.


Related issues

Related to Redmine - Feature #1339: Comments on revisionsNew2008-05-31

Actions
Actions #1

Updated by Carl Nygard over 15 years ago

There is a project called codestriker that provides these capabilities. It is a separate system, but it integrates with most SCM systems. I've used it and it's pretty decent.

Perhaps you can integrate something already written instead of re-inventing the wheel.

Actions #2

Updated by Daniel N over 15 years ago

Yes, something like "codestriker-functionality" to comment "source" would be cool. I´d like to see this for patches as well as for normal commits/revisions as described in #1339

Actions #3

Updated by Jean-Philippe Lang over 15 years ago

  • Target version deleted (0.9.0)
Actions #4

Updated by Benjamin Schunn over 7 years ago

functionality of another tool, so I think this could be closed.

Actions #5

Updated by Toshi MARUYAMA over 7 years ago

Actions #6

Updated by Toshi MARUYAMA over 7 years ago

Benjamin Schunn wrote:

functionality of another tool

"views the attached file" is Redmine core feature.

Actions

Also available in: Atom PDF