Patch #18059
Activity when issue change assigned to.
Status: | Resolved | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Activity view | |||
Target version: | Candidate for next major release |
Description
Hi. There is patch to change activity for project. It's will shows you when issue status was changed, assigned_to was changed, and when status and assigned_to was changed together.
I wrote test for this and everything works fine.
See files.
History
#1
Updated by Marcin Świątkiewicz over 8 years ago
- File diff_all_in_one.diff
added
Sory. Now every changes in one diff file.
#2
Updated by Toshi MARUYAMA over 8 years ago
- Target version set to 2.6.0
#3
Updated by Toshi MARUYAMA over 8 years ago
- Description updated (diff)
#4
Updated by Toshi MARUYAMA over 8 years ago
- Target version changed from 2.6.0 to Candidate for next major release
#5
Updated by Toshi MARUYAMA over 8 years ago
- "Now assigned to" should be i18n.
- Asserting string should be literal not variable (e.g. #{User.find(2).name})
- I don't know why you use ".to_s[29..102]" for asserting.
- Please use #{ESCAPED_UCANT} instead of "Can't" for Rails4 porting.
#6
Updated by Mischa The Evil over 8 years ago
- Priority changed from Low to Normal
I think this could be an interesting change, so I quick-tested the patch attached in note-1 on a test deployment of Redmine source:/trunk@134321. Besides the points mentioned by Toshi, I have some additional remarks about the patch:
- some existing unit and functional tests need to be adjusted/tested/fixed to match the new fixtures: some tests produce failures currently2
- bug/typo (?) in
Journal#event_title
:data_for_assigned_and_status
is called without checking ifnew_status
is blank or not - tests are not covering all cases; previous issue is not covered for example
- we should not have blank event titles (they're occurring eg. when only a note is added): blank event titles can't be clicked obviously
- event titles should be more standardized and consistent
I want to emphasize that I like the idea behind this change, but I think it really needs some improvements before implementation.
Mischa.
#7
Updated by Marcin Świątkiewicz over 8 years ago
- File fixed_bugs_activity.diff
added
I fixed bugs, change test for few more cases, now tests pass. Yes, there was few typo mistakes.
See diff.
Marcin.
#8
Updated by Marcin Świątkiewicz over 7 years ago
- Status changed from New to Resolved
Here is a plugin for this improvement.
Tested with Travis on Redmine 3.1.0 and 3.0.3.
Repo: https://github.com/efigence/redmine_show_assigned_to_activity
have fun.
Marcin.