Project

General

Profile

Actions
Copy link

Patch #18059

open

Activity when issue change assigned to.

Added by Marcin Świątkiewicz almost 11 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Activity view
Target version:
Candidate for next major release
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi. There is patch to change activity for project. It's will shows you when issue status was changed, assigned_to was changed, and when status and assigned_to was changed together.

I wrote test for this and everything works fine.

See files.

Files

Download all files
fixtures_journal.diff (372 Bytes) fixtures_journal.diff Marcin Świątkiewicz, 2014-10-10 13:57
fixtures_journal_details.diff (577 Bytes) fixtures_journal_details.diff Marcin Świątkiewicz, 2014-10-10 13:57
activities_controller_test.diff (1.27 KB) activities_controller_test.diff Marcin Świątkiewicz, 2014-10-10 13:57
change_activity_for_journal.diff (5.63 KB) change_activity_for_journal.diff Marcin Świątkiewicz, 2014-10-10 13:57
diff_all_in_one.diff (6.81 KB) diff_all_in_one.diff Marcin Świątkiewicz, 2014-10-10 14:15
fixed_bugs_activity.diff (9.83 KB) fixed_bugs_activity.diff Marcin Świątkiewicz, 2014-10-20 11:35
Actions
Copy link
 #1

Updated by Marcin Świątkiewicz almost 11 years ago

Sory. Now every changes in one diff file.

Actions
Copy link
 #2

Updated by Toshi MARUYAMA almost 11 years ago

  • Target version set to 2.6.0
Actions
Copy link
 #3

Updated by Toshi MARUYAMA almost 11 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Toshi MARUYAMA almost 11 years ago

  • Target version changed from 2.6.0 to Candidate for next major release
Actions
Copy link
 #5

Updated by Toshi MARUYAMA almost 11 years ago

  • "Now assigned to" should be i18n.
  • Asserting string should be literal not variable (e.g. #{User.find(2).name})
  • I don't know why you use ".to_s[29..102]" for asserting.
  • Please use #{ESCAPED_UCANT} instead of "Can't" for Rails4 porting.
Actions
Copy link
 #6

Updated by Mischa The Evil almost 11 years ago

  • Priority changed from Low to Normal
I think this could be an interesting change, so I quick-tested the patch attached in note-1 on a test deployment of Redmine source:/trunk@134321. Besides the points mentioned by Toshi, I have some additional remarks about the patch:
  • some existing unit and functional tests need to be adjusted/tested/fixed to match the new fixtures: some tests produce failures currently2
  • bug/typo (?) in Journal#event_title: data_for_assigned_and_status is called without checking if new_status is blank or not
  • tests are not covering all cases; previous issue is not covered for example
  • we should not have blank event titles (they're occurring eg. when only a note is added): blank event titles can't be clicked obviously
  • event titles should be more standardized and consistent

I want to emphasize that I like the idea behind this change, but I think it really needs some improvements before implementation.

Mischa.

1 Details about my test environment...

2 Test suite output (unrelated output omitted)...

Actions
Copy link
 #7

Updated by Marcin Świątkiewicz over 10 years ago

I fixed bugs, change test for few more cases, now tests pass. Yes, there was few typo mistakes.

See diff.

Marcin.

Actions
Copy link
 #8

Updated by Marcin Świątkiewicz almost 10 years ago

  • Status changed from New to Resolved

Here is a plugin for this improvement.

Tested with Travis on Redmine 3.1.0 and 3.0.3.

Repo: https://github.com/efigence/redmine_show_assigned_to_activity

have fun.

Marcin.

Actions
Copy link

Also available in: Atom PDF