Defect #18499
Localisation not set correctly on authenticity token errors
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | I18n | |||
| Target version: | 2.6.1 | |||
| Resolution: | Fixed | Affected version: | 2.6.0 |
18499.patch 
(1.28 KB)
Associated revisions
Localisation not set correctly on authenticity token errors (#18499).
Patch by Felix Schäfer.
History
#1
Updated by Felix Schäfer about 6 years ago
- File 18499.patch added
This error was discovered on Planio. The attached patch fixes the problem and adds a test to make sure it stays that way.
Maybe set_localization should even be called at the end of logged_user= to make sure a user change also changes the locale? (I haven't tested that though).
#2
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.6.1
- Resolution set to Fixed
Patch committed in r13670, thanks.
Felix Schäfer wrote:
Maybe
set_localizationshould even be called at the end oflogged_user=to make sure a user change also changes the locale? (I haven't tested that though).
Not sure it would improve things, most #logged_user= are followed by a redirect. And #set_localization would still have to be called in a few places.
#3
Updated by Felix Schäfer about 6 years ago
Thanks for the quick merge!
#4
Updated by Denis Savitskiy about 6 years ago
Pity, it doesn't help in 2.6.0develop
#5
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from Resolved to Closed