Project

General

Profile

Actions
Copy link

Defect #18629

closed

PDF Export removes separating space after tables

Added by @ go2null almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
PDF export
Target version:
2.6.1
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
2.6.0

Description

With the switch to the new PDF gem, the space after tables are removed resulting in the element after a table displaying immediately under the table.

Please see attached screenshots.
  1. html.png: this is what is displayed on the issue view.
  2. rbpdf.png: This is what is generated by the new pdf parser.
  3. rbpdf-no-remove-trailing-multiple-spaces.png: with the following change
    # /usr/lib/ruby/gems/1.9.1/gems/rbpdf-1.18.2/lib/rbpdf.rb

-10667   html.gsub!(/<\/(table|tr|td|th|blockquote|dd|dl|div|dt|h1|h2|h3|h4|h5|h6|hr|li|ol|ul|p)>[\s]+</, '</\\1><')
+10667   html.gsub!(/<\/(tr|td|th|blockquote|dd|dl|div|dt|h1|h2|h3|h4|h5|h6|hr|li|ol|ul|p)>[\s]+</, '</\\1><')
  4. pdf-export-with-p-element.png: with the following change
    # lib/redmine/export/pdf.rb

+65   html.gsub!(/<\/table>/,'</table><p></p>')

Files

Download all files
rbpdf-no-remove-trailing-multiple-spaces.png (13.2 KB) rbpdf-no-remove-trailing-multiple-spaces.png @ go2null, 2014-12-12 19:41
pdf-export-with-p-element.png (13.3 KB) pdf-export-with-p-element.png @ go2null, 2014-12-12 19:41
rbpdf.png (11.8 KB) rbpdf.png @ go2null, 2014-12-12 19:41
html.png (9.08 KB) html.png @ go2null, 2014-12-12 19:41
rbpdf-1.18.3.png (25.3 KB) rbpdf-1.18.3.png Jun NAITOH, 2014-12-18 00:09
Actions
Copy link

Also available in: Atom PDF