Patch #18818
TimeEntry acts_as_activity_provider scope should joins(:project)
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Code cleanup/refactoring | |||
Target version: | 3.0.0 |
Description
TimeEntry acts_as_activity_provider scope should join project, not just preload it
Associated revisions
TimeEntry acts_as_activity_provider scope should joins(:project) (#18818).
Patch by Ondřej Ezr.
History
#1
Updated by Toshi MARUYAMA almost 6 years ago
- Target version set to 3.0.0
#2
Updated by Jean-Philippe Lang almost 6 years ago
- Subject changed from TimeEntry acts_as_activity_provider scope to TimeEntry acts_as_activity_provider scope should joins(:project)
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed in r13971, thanks.
#3
Updated by Toshi MARUYAMA almost 6 years ago
For the record:
:scope => preload(:project) was introduced by r13482 (#14534).
=== (+11,-5) app/models/time_entry.rb ===
@@ -35,7 +35,7 @@
acts_as_activity_provider :timestamp => "#{table_name}.created_on",
:author_key => :user_id,
- :find_options => {:include => :project}
+ :scope => preload(:project)