Project

General

Profile

Actions
Copy link

Patch #18818

closed

TimeEntry acts_as_activity_provider scope should joins(:project)

Added by Ondřej Ezr about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
3.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

TimeEntry acts_as_activity_provider scope should join project, not just preload it

Files

activity_scope_on_time_entry.patch (629 Bytes) activity_scope_on_time_entry.patch Ondřej Ezr, 2015-01-13 01:09
Actions
Copy link
 #1

Updated by Toshi MARUYAMA about 8 years ago

  • Target version set to 3.0.0
Actions
Copy link
 #2

Updated by Jean-Philippe Lang about 8 years ago

  • Subject changed from TimeEntry acts_as_activity_provider scope to TimeEntry acts_as_activity_provider scope should joins(:project)
  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed in r13971, thanks.

Actions
Copy link
 #3

Updated by Toshi MARUYAMA about 8 years ago

For the record:

:scope => preload(:project) was introduced by r13482 (#14534).

=== (+11,-5) app/models/time_entry.rb ===
@@ -35,7 +35,7 @@

   acts_as_activity_provider :timestamp => "#{table_name}.created_on",
                             :author_key => :user_id,
-                            :find_options => {:include => :project}
+                            :scope => preload(:project)

So target 3.0.0 is no need.
But 3.0.0 was already released.

Actions
Copy link

Also available in: Atom PDF