Patch #18818
closed
TimeEntry acts_as_activity_provider scope should joins(:project)
Added by Ondřej Ezr almost 10 years ago.
Updated over 9 years ago.
Category:
Code cleanup/refactoring
Description
TimeEntry acts_as_activity_provider scope should join project, not just preload it
Files
- Target version set to 3.0.0
- Subject changed from TimeEntry acts_as_activity_provider scope to TimeEntry acts_as_activity_provider scope should joins(:project)
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
For the record:
:scope => preload(:project) was introduced by r13482 (#14534).
=== (+11,-5) app/models/time_entry.rb ===
@@ -35,7 +35,7 @@
acts_as_activity_provider :timestamp => "#{table_name}.created_on",
:author_key => :user_id,
- :find_options => {:include => :project}
+ :scope => preload(:project)
So target 3.0.0 is no need.
But 3.0.0 was already released.
Also available in: Atom
PDF