Defect #18922: rdm-mailhandler.rb should catch EOFError - Redmine

Actions

Copy link

Defect #18922

closed

rdm-mailhandler.rb should catch EOFError

Added by Go MAEDA almost 10 years ago. Updated almost 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Email receiving

Target version:

2.6.2

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

2.6.1

Description

rdm-mailhandler.rb should catch EOFError in addition to SystemCallError at source:trunk/extra/mail_handler/rdm-mailhandler.rb@13872#L132.

If communications between rdm-mailhandler.rb and Redmine are terminated while rdm-mailhandler.rb talking to Redmine, Net::HTTP raises EOFError and rdm-mailhandler stops unexpectedly because it does not catch EOFError. The email will be bounced.

error mail from MTA error mail from MTA

This is the mail system at host mta.example.com

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to postmaster.

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

                   The mail system

<redmine@example.com>: Command died
    with status 1: "/some/where/redmine/extra/mail_handler/rdm-mailhandler.rb
    --url http://redmine.example.com/redmine/ --key **********
    --allow-override=tracker,category,priority --project=someproject
    --unknown-user=accept --no-permission-check". Command output:
    /usr/share/ruby/2.0/net/protocol.rb:153:in `read_nonblock': end of file
    reached (EOFError)  from /usr/share/ruby/2.0/net/protocol.rb:153:in
    `rbuf_fill'  from /usr/share/ruby/2.0/net/protocol.rb:134:in `readuntil'
    from /usr/share/ruby/2.0/net/protocol.rb:144:in `readline'  from
    /usr/share/ruby/2.0/net/http/response.rb:39:in `read_status_line'  from
    /usr/share/ruby/2.0/net/http/response.rb:28:in `read_new'  from
    /usr/share/ruby/2.0/net/http.rb:1406:in `block in transport_request'  from
    /usr/share/ruby/2.0/net/http.rb:1403:in `catch'  from
    /usr/share/ruby/2.0/net/http.rb:1403:in `transport_request'  from
    /usr/share/ruby/2.0/net/http.rb:1376:in `request'  from
    /some/where/redmine/extra/mail_handler/rdm-mailhandler.rb:36:in `block in
    post_form'  from /usr/share/ruby/2.0/net/http.rb:852:in `start'  from
    /some/where/redmine/extra/mail_handler/rdm-mailhandler.rb:36:in `post_form'
    from /some/where/redmine/extra/mail_handler/rdm-mailhandler.rb:131:in
    `submit'  from
    /some/where/redmine/extra/mail_handler/rdm-mailhandler.rb:178:in `<main>'

We can avoid the preceding by this patch. The email will be deferred, not bounced.

Files

Download all files

catch-EOFError.diff (669 Bytes) catch-EOFError.diff		Go MAEDA, 2015-01-21 09:44
catch-IOError.diff (668 Bytes) catch-IOError.diff		Go MAEDA, 2015-02-01 03:16