Defect #19252
closed
2 IssuesController tests fail with SQLite3 database
0%
Description
Hi, running the test cases of Redmine 3.0.0 using an SQLite3 backend I encountered the following two errors:
$ ruby test/functional/issues_controller_test.rb -n test_index_with_query_grouped_by_tracker_in_reverse_order Run options: -n test_index_with_query_grouped_by_tracker_in_reverse_order --seed 925 # Running: F Finished in 2.918891s, 0.3426 runs/s, 0.6852 assertions/s. 1) Failure: IssuesControllerTest#test_index_with_query_grouped_by_tracker_in_reverse_order [test/functional/issues_controller_test.rb:346]: Expected: [3, 2, 1] Actual: [2, 3, 1] 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
and
$ ruby test/functional/issues_controller_test.rb -n test_index_with_query_grouped_by_tracker_in_normal_order Run options: -n test_index_with_query_grouped_by_tracker_in_normal_order --seed 7058 # Running: F Finished in 2.245884s, 0.4453 runs/s, 0.8905 assertions/s. 1) Failure: IssuesControllerTest#test_index_with_query_grouped_by_tracker_in_normal_order [test/functional/issues_controller_test.rb:336]: Expected: [1, 2, 3] Actual: [1, 3, 2] 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
I'm using sqlite3 (1.3.10) and Ruby 2.0.0-p598. Please ask for more information if you need some.
Updated by Toshi MARUYAMA over 9 years ago
- Status changed from New to Confirmed
- Target version set to 3.0.1
Confirmed.
I tried Rails 4.2.1.rc3, but no changes.
sqlite3: 3.8.8
Ruby: ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux]
Updated by Toshi MARUYAMA over 9 years ago
Toshi MARUYAMA wrote:
sqlite3: 3.8.8
Ruby: ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux]
On CentOS6 replaced at #19106#note-8.
Updated by Toshi MARUYAMA over 9 years ago
I can reproduce on Windows ruby 1.9.3p551 (2014-11-13) [i386-mingw32].
It seems it uses sqlite3 >= 3.8.7.1.
https://github.com/sparklemotion/sqlite3-ruby/blame/970eea5dcdc3017ff485/tasks/native.rake#L8
Updated by Jean-Philippe Lang over 9 years ago
- Target version changed from 3.0.1 to Candidate for next minor release
Adding some debug info in IssueQuery#issues shows that ActiveRecord does not return the results in the correct order (while doing a #pluck does):
puts scope.pluck(:tracker_id)*',' puts scope.to_a.map(&:tracker_id)*','
gives:
3,2,2,1,1,1,1,1,1 2,2,3,1,1,1,1,1,1
The query that is executed has a proper ORDER BY statement: ORDER BY trackers.position DESC, issues.id DESC (trackers position equals tracker id in test fixtures). Running the query on the db manually returns the rows in the correct order so the problem is not on the database.
Updated by Toshi MARUYAMA over 9 years ago
- Status changed from Confirmed to Closed
- Target version deleted (
Candidate for next minor release) - Resolution set to Wont fix
This is simplified SQL.
SELECT "issues"."id" AS t0_r0, "issues"."tracker_id" AS t0_r1 FROM "issues" LEFT OUTER JOIN "trackers" ON "trackers"."id" = "issues"."tracker_id" ORDER BY trackers.position
Tests passes on my CentOS7 sqlite3 built by sqlite-3.8.9-1.fc23.src.rpm.
$ sqlite3 --version 3.8.9 2015-04-08 12:16:33 8a8ffc862e96f57aa698f93de10dee28e69f6e09
It seems this issues fixed in sqlite 3.8.9.
Incorrect result when a LEFT JOIN provides the qualifying constraint for a partial index