Redmine

Toshi MARUYAMA wrote:

In your patch, '/home/redmine/redmine-ignored-attachments/*' is hard-coded.

Where do you propose to save the files to be ignored or theirs hashes? I thought about the Files section but there is no ability to separate useful files from the files to be ignored except using separate project for that or using special filename or description e.g. "ignored".

And saving and comparing files anytime is very expensive.
I think it is better to use hash (e.g. md5sum).

I agree that using hash would be better.

Path should be configurable such as "attachments_storage_path".
source:tags/3.0.3/config/configuration.yml.example#L69

This code works perfectly for me in Redmine 3.0 on Windows.
I implemented the MD5-check.

require 'digest/md5'
    ignoreddir = "C:\\redmine\\redmine-ignored-attachments\\" 
    md5_attachment = Digest::MD5.hexdigest(attachment.body.decoded)
    Dir.foreach(ignoreddir) do |ignoredf|
        next if ignoredf  '.' or ignoredf  '..'
        md5_ignored = Digest::MD5.file(File.join(ignoreddir, ignoredf)).hexdigest
        if md5_ignored == md5_attachment
          logger.info "MailHandler: ignoring attachment #{attachment.filename} (#{md5_attachment}) matching #{ignoredf} (#{md5_attachment})" 
          return false
        end
    end

To do:
- Configurable path in configuration.yml
- Cache MD5 hashes in database to avoid high load on hard drive because of hashing every file every time an email comes in

For a very easy optimization you might first compare the size of the files. If the sizes differ there is no need to calculate the MD5 of the ignored file.

same painful problem here :'(

just eliminating duplicated attachments (#15257) would also help.

Tested on redmine 5.0.5 and it did not work.
There was two == missing on the next line.
The fixed version is:

require 'digest/md5'
    ignoreddir = "C:\\redmine\\redmine-ignored-attachments\\" 
    md5_attachment = Digest::MD5.hexdigest(attachment.body.decoded)
    Dir.foreach(ignoreddir) do |ignoredf|
        next if ignoredf == '.' or ignoredf == '..'
        md5_ignored = Digest::MD5.file(File.join(ignoreddir, ignoredf)).hexdigest
        if md5_ignored == md5_attachment
          logger.info "MailHandler: ignoring attachment #{attachment.filename} (#{md5_attachment}) matching #{ignoredf} (#{md5_attachment})" 
          return false
        end
    end