Project

General

Profile

Actions

Feature #19885

closed

Raise time entries comments limit to 1024

Added by Future Link Corporation pkgsrc team almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Low
Category:
Time tracking
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

See: source:/trunk/app/models/time_entry.rb#L42

The comments field in the time_entries table is defined as having a length of 1024 characters:

Click to expand @time_entries@ table definition...

Yet, user comments are truncated at 255:

Click to expand patch...

Let's not do that. :)

Note: This patch (partly) makes the comment field mandatory. That might not be what you want. It would be nice to have a way to require this field without patching the application though. :)


Related issues

Copied to Redmine - Feature #19886: Raise wiki edits comments limit to 1024ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Future Link Corporation pkgsrc team almost 9 years ago

  • Copied to Feature #19886: Raise wiki edits comments limit to 1024 added
Actions #2

Updated by Future Link Corporation pkgsrc team almost 9 years ago

Here is a patch for source:/trunk/app/views/timelog/_form.html.erb as well:

Click to expand patch...

Again, noting that we're making the field mandatory, which might not be what you want (POLA).

Actions #3

Updated by Toshi MARUYAMA almost 9 years ago

  • Status changed from New to Needs feedback

"comments" of "time_entries" is defined as 255.
source:tags/3.0.3/db/migrate/032_create_time_entries.rb#L8

I think you changed manually.

Actions #4

Updated by Future Link Corporation pkgsrc team almost 9 years ago

Yes, you are correct. We did. Can that field be made longer by default? The length of 255 characters is rather short and doesn't allow for detailed time entries.

Actions #5

Updated by Toshi MARUYAMA over 8 years ago

See r4402.

Actions #6

Updated by Future Link Corporation pkgsrc team over 8 years ago

The diff you referenced doesn't apply to the time entries comment field.

Actions #7

Updated by Toshi MARUYAMA over 8 years ago

Actions #8

Updated by Future Link Corporation pkgsrc team over 8 years ago

Yes, I understand that and we've done it. The point is that the stock password length between what the view allows and what the DB allows, by default, don't match. Thus, these comments get limited unnecessarily. Same deal for #19886. Please, apply these patches in this issue and #19886.

Actions #9

Updated by Toshi MARUYAMA over 8 years ago

  • Tracker changed from Patch to Feature
  • Status changed from Needs feedback to New

Because there is no completed patch, I change tracker.

Actions #10

Updated by Toshi MARUYAMA over 8 years ago

  • Target version set to 3.2.0
Actions #11

Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from Comment field length for time entries is unnecessarily short to Raise time entries comments limit to 1024
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Limit raised to 1024 in r14621.

Actions

Also available in: Atom PDF