Patch #20300: Redmine development mode - few blockers - Redmine

Actions

Patch #20300

closed

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

Start date:

Due date:

% Done:

Estimated time:

Description

Redmine is pretty prepared for a development mode, but with a plugins and patching concerned, there are a few blockers for it's funcionality.

redmine/i18n is required in redmine.rb, but row above it is autoloaded by rails and thus both mechanisms are loading it. It is problem in some of my patches. But it is basically bad idea to mix those behaviours. ( My vote goes for a rails autoloading... )
Redmine::Hook::Helper is in file, which is required, but is patching ApplicationHelper and that is loaded by Rails autoloading. So its patch is forgotten after reloading
redmine/themes.rb defines ApplicationHelper, but it gets into problems, if there is a patch for it in plugin, which redefines ApplicationHelper method. Rails do not load it - it is loaded, but does not have the method defined. It works only if patch is after a controller invocation, because it load it by path and do not care if it is defined. But it bassically defines the model and avoiding Rails autoloading.

I have created a patch for every issue I have found.

Files

Download all files

redmine_i18n_loaded_automaticaly.patch (377 Bytes) redmine_i18n_loaded_automaticaly.patch	1)	Ondřej Ezr, 2015-07-13 00:15
themes_helper.patch (495 Bytes) themes_helper.patch	3)	Ondřej Ezr, 2015-07-13 00:15
hook_availability_after_reload.patch (571 Bytes) hook_availability_after_reload.patch	2)	Ondřej Ezr, 2015-07-13 00:16