Project

General

Profile

Actions

Patch #21245

closed

UI/CSS refinements, part 1

Added by Daniel Ritz over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

A few patches for UI/CSS that allow better/easier styling in themes.

  • Patches 0001 and 0002:
    Replaces all uses of image_tag() to render icons with icon-* definitions. This makes is possible to replace all these icons with Font-based icons, e.g. FontAwesome.
  • Patch 0003:
    A unimportant change to use the PDF icon for "Also available in PDF" links
  • Patch 0004:
    Updates pagination to use <ul> and <li> to render the pagination part
  • Patch 0005:
    Building on top of patch 0004, changes pagination to a GitHub like design that also looks and feels nice in responsive mode

Based on r14881, everything passes "rake test" and is tested in Firefox 42, Safari 9 and Chrome 46.

More to come :)


Files


Related issues

Is duplicate of Redmine - Patch #21256: Use CSS instead of image_tag() to show icons for better theming supportClosedJean-Philippe Lang

Actions
Is duplicate of Redmine - Patch #21257: Use PDF icon for "Also available in PDF"New

Actions
Is duplicate of Redmine - Patch #21258: Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive modeClosedJean-Philippe Lang

Actions
Actions #2

Updated by Toshi MARUYAMA over 8 years ago

  • Status changed from New to Needs feedback

Could you separate patches to new issues?
It seems three group [1, 2], [3], [4, 5].

Actions #3

Updated by Daniel Ritz over 8 years ago

Done:
  • 1,2: #21256. I folded the two patches into one and also corrected accidental duplicated CSS rules.
  • 3: #21257. Same as here.
  • 4,5: #21258. With minor correction in positioning, plus screen shot included.
Actions #4

Updated by Go MAEDA over 8 years ago

  • Status changed from Needs feedback to Closed

Thanks for creating issues.

Actions #5

Updated by Go MAEDA over 8 years ago

  • Is duplicate of Patch #21256: Use CSS instead of image_tag() to show icons for better theming support added
Actions #6

Updated by Go MAEDA over 8 years ago

  • Is duplicate of Patch #21257: Use PDF icon for "Also available in PDF" added
Actions #7

Updated by Go MAEDA over 8 years ago

  • Is duplicate of Patch #21258: Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode added
Actions

Also available in: Atom PDF