Patch #21245: UI/CSS refinements, part 1 - Redmine

Actions

Patch #21245

closed

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

Start date:

Due date:

% Done:

Estimated time:

Description

A few patches for UI/CSS that allow better/easier styling in themes.

Patches 0001 and 0002:
Replaces all uses of image_tag() to render icons with icon-* definitions. This makes is possible to replace all these icons with Font-based icons, e.g. FontAwesome.
Patch 0003:
A unimportant change to use the PDF icon for "Also available in PDF" links
Patch 0004:
Updates pagination to use <ul> and <li> to render the pagination part
Patch 0005:
Building on top of patch 0004, changes pagination to a GitHub like design that also looks and feels nice in responsive mode

Based on r14881, everything passes "rake test" and is tested in Firefox 42, Safari 9 and Chrome 46.

More to come :)

Files

Download all files

0001-Replace-uses-of-image_tag-with-CSS-part-1-admin.patch (22.7 KB) 0001-Replace-uses-of-image_tag-with-CSS-part-1-admin.patch		Daniel Ritz, 2015-11-16 21:31
0002-Replace-uses-of-image_tag-with-CSS-part-2.patch (22.4 KB) 0002-Replace-uses-of-image_tag-with-CSS-part-2.patch		Daniel Ritz, 2015-11-16 21:31
0003-Use-PDF-icon-for-Also-available-in-PDF.patch (1002 Bytes) 0003-Use-PDF-icon-for-Also-available-in-PDF.patch		Daniel Ritz, 2015-11-16 21:31
0004-Pagination-use-ul-to-do-pagination-for-better-stylin.patch (12.7 KB) 0004-Pagination-use-ul-to-do-pagination-for-better-stylin.patch		Daniel Ritz, 2015-11-16 21:31
0005-Pagination-change-to-a-GitHub-like-style.patch (1.72 KB) 0005-Pagination-change-to-a-GitHub-like-style.patch		Daniel Ritz, 2015-11-16 21:31

Related issues

Actions

Actions

Could you separate patches to new issues?
It seems three group [1, 2], [3], [4, 5].

Actions

Done:

1,2: #21256. I folded the two patches into one and also corrected accidental duplicated CSS rules.
3: #21257. Same as here.
4,5: #21258. With minor correction in positioning, plus screen shot included.

Actions