Defect #21263
closed
Wiki lists in the sidebar are broken
Added by Ezequiel Hernandez about 9 years ago.
Updated almost 9 years ago.
Description
The list in the Sidebar didn't work anymore since 2.5.X version. The same problem appear with
{{child_pages}} macro.
I tested on demo.redmine.org with the same result.
But if you put an orderer list (with #) it works.
This is due to changes in the Redmine CSS in 2.4.0 that added lines 80 and 81 in the main Redmine CSS, see also #13242.
This is my redmine:
Redmine 2.6
Ruby 2.2
Files
Minimal fix for the problem attached:
- Wrap the wiki text a div.wiki (which is required anyway for proper wiki text styling)
- Undo the styles of form
#sidebar xyz for #sidebar div.wiki xyz which works but is a bit ugly
The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with #sidebar .content xyz. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.
- Category set to UI
- Target version set to 3.3.0
Daniel Ritz wrote:
The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with #sidebar .content xyz. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.
Should I implement that or is the minimal fix enough?
Daniel Ritz wrote:
The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class
Would you do that by adding a div in each view where there is some content for the sidebar?
If so, I'd prefer the patch you've already submitted.
Jean-Philippe Lang wrote:
Daniel Ritz wrote:
The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class
Would you do that by adding a div in each view where there is some content for the sidebar?
If so, I'd prefer the patch you've already submitted.
Yeah, pretty much. Thinking about it some more, the minimal fix is better as it allows sidebar content at any level to insert .wiki and formatted text that just works.
- Subject changed from List in Sidebar to Wiki lists in the sidebar are broken
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version changed from 3.3.0 to 3.2.1
- Resolution set to Fixed
Patch committed, thanks for the feedback.
- Status changed from Resolved to Closed
Also available in: Atom
PDF
Updated by 
Updated by Toshi MARUYAMA 
Updated by