Project

General

Profile

Actions

Defect #2149

closed

Git Adapter date parsing ignores timezone

Added by Kevin Chan about 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
SCM
Target version:
Start date:
2008-11-08
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Git adapter uses Time.parse() on the date string, in the format Sat Nov 8 02:20:44 2008 -0800

TIme.parse() is unable to parse the timezone in the above date correctly:

in irb:

>> Time.parse("Sat Nov 8 02:20:44 2008 -0800")
=> Sat Nov 08 02:20:44 -0600 2008

The correct output should be the following (notice the placement of the year segment)

>> Time.parse("Sat Nov 8 2008 02:20:44 -0800")
=> Sat Nov 08 04:20:44 -0600 2008

This is causing a major issue with the repository to have incorrect times.

Actions #1

Updated by Jean-Philippe Lang about 16 years ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

I added --date=iso option to git commands in r1995.
That should fix the date parsing problem. Can you confirm?

Actions #2

Updated by Kevin Chan about 16 years ago

You changed path to git in your commit.

Might want to change that back.

Actions #3

Updated by Jean-Philippe Lang about 16 years ago

Sorry, fixed. Can I close this ticket ?

Actions #4

Updated by Kevin Chan about 16 years ago

Jean-Philippe Lang wrote:

Sorry, fixed. Can I close this ticket ?

Yea, works great.

Actions #5

Updated by Jean-Philippe Lang about 16 years ago

  • Status changed from Resolved to Closed
  • Target version set to 0.8
Actions

Also available in: Atom PDF