Project

General

Profile

Actions
Copy link

Patch #21582

closed

Performance in User#roles_for_project

Added by Ondřej Ezr almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Performance
Target version:
3.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

roles are duplicating a scope not an result, thus every hit produce a query, cached, but it is still not desired.

Files

roles_duping_scope.diff (450 Bytes) roles_duping_scope.diff dup ary not scope Ondřej Ezr, 2015-12-22 00:32
Actions
Copy link
 #1

Updated by Go MAEDA over 7 years ago

  • Target version set to 3.3.0

I think we can remove the last 'dup' method from Ondřej Ezr's patch because ActiveRecord::Associations::CollectionProxy#to_a returns copied objects.

# File activerecord/lib/active_record/associations/collection_proxy.rb, line 943
      def to_ary
        load_target.dup
      end
Actions
Copy link
 #2

Updated by Ondřej Ezr over 7 years ago

true, I just put to_a there with heureka feeling, but you are right dup is meaningless now :)

Actions
Copy link
 #3

Updated by Go MAEDA over 7 years ago

Thanks for your feedback. Nice eureka!

Actions
Copy link
 #4

Updated by Jean-Philippe Lang over 7 years ago

  • Subject changed from Performance in roles to Performance in User#roles_for_project
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions
Copy link

Also available in: Atom PDF