Project

General

Profile

Actions
Copy link

Patch #22074

closed

Prevent username from overlapping in mobile menu

Added by Felix Gliesche over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI - Responsive
Target version:
3.2.1
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Under certain cirumstances the username shown in the mobile menu can break into another line overlapping the next menu item. For example if the username is too long and contains a '-':

I am attaching a patch which fixes this behaviour by avoiding line breaks and by adding text-overflow: ellipsis

Files

Download all files
after.png (100 KB) after.png Felix Gliesche, 2016-02-17 23:29
before.png (101 KB) before.png Felix Gliesche, 2016-02-17 23:29
0001-Prevent-username-from-overlapping-in-mobile-menu.patch (760 Bytes) 0001-Prevent-username-from-overlapping-in-mobile-menu.patch Felix Gliesche, 2016-02-17 23:29
0002-Expand-username-to-cover-whole-line-in-mobile-menu.patch (744 Bytes) 0002-Expand-username-to-cover-whole-line-in-mobile-menu.patch Gregor Schmidt, 2016-02-19 16:06
screen-capture-30.png (16.8 KB) screen-capture-30.png Gregor Schmidt, 2016-02-19 16:07
Actions
Copy link
 #1

Updated by Go MAEDA over 9 years ago

  • Target version set to 3.2.1

The fix works fine for me. Setting target version to 3.2.1.

Actions
Copy link
 #2

Updated by Gregor Schmidt over 9 years ago

Sorry for hijacking this issue, but my problem is related.

If the user name is really short, e.g. a single letter, the menu entry does not cover the whole width, in contrast to the other menu entries. This makes touching the link needlessly complicated.

The second attached patch expands the user name link to cover the whole line.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 9 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Both patches are merged in 3.2, thanks.

Actions
Copy link

Also available in: Atom PDF