Project

General

Profile

Actions
Copy link

Defect #23395

closed

Markdown formatter crashes

Added by Andreas Kohlbecker over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Duplicate
Affected version:
3.3.0

Description

The markdown formatter crashes redmine 3.3.0 on interpreting the following incomplete markdown snipped.

 [areas.php" and "points.php]()

This markdown has been created by converting textile to markdown using pandoc, see also #22005

Related issues

Is duplicate of Redmine - Defect #23246: Saving an empty Markdown image tag in Wiki pages causes internal server errorClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Andreas Kohlbecker over 8 years ago

This is the according stack trace:

  lib/redmine/helpers/url.rb:26:in `uri_with_safe_scheme?'
  lib/redmine/wiki_formatting/markdown/formatter.rb:28:in `link'
  lib/redmine/wiki_formatting/markdown/formatter.rb:60:in `render'
  lib/redmine/wiki_formatting/markdown/formatter.rb:60:in `to_html'
  lib/redmine/wiki_formatting.rb:89:in `to_html'
  app/helpers/application_helper.rb:598:in `textilizable'
  app/views/wiki/_content.html.erb:2:in `_app_views_wiki__content_html_erb__4530570473966196404_68637680'
  app/views/wiki/show.html.erb:47:in `_app_views_wiki_show_html_erb___3335969183249968685_67365760'
  app/controllers/wiki_controller.rb:114:in `show'
  lib/redmine/sudo_mode.rb:63:in `sudo_mode'

It is most probably the missing URI which processed in a not nil save manner which is causing the crash.

Actions
Copy link
 #2

Updated by Toshi MARUYAMA over 8 years ago

  • Category changed from Wiki to Text formatting
Actions
Copy link
 #3

Updated by Toshi MARUYAMA over 8 years ago

  • Related to Defect #23246: Saving an empty Markdown image tag in Wiki pages causes internal server error added
Actions
Copy link
 #4

Updated by Toshi MARUYAMA over 8 years ago

  • Status changed from New to Needs feedback

I cannot reproduce on 3.3-stable r15722. I think #23246 fixed it.

Actions
Copy link
 #5

Updated by Viktor Berke over 8 years ago

I cannot reproduce it either with r15607 applied.

You can try it for yourself, Andreas, just apply this to your instance:

http://www.redmine.org/projects/redmine/repository/revisions/15607/diff/trunk/lib/redmine/helpers/url.rb

Actions
Copy link
 #6

Updated by Andreas Kohlbecker over 8 years ago

I can confirm that #23246 fixed it

Actions
Copy link
 #7

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Needs feedback to Closed
  • Resolution set to Duplicate

Thanks for your feedback, the fix will be included in 3.3.1 and 3.2.4.

Actions
Copy link
 #8

Updated by Toshi MARUYAMA over 8 years ago

  • Related to deleted (Defect #23246: Saving an empty Markdown image tag in Wiki pages causes internal server error)
Actions
Copy link
 #9

Updated by Toshi MARUYAMA over 8 years ago

  • Is duplicate of Defect #23246: Saving an empty Markdown image tag in Wiki pages causes internal server error added
Actions
Copy link

Also available in: Atom PDF