Project

General

Profile

Actions
Copy link

Defect #23839

closed

"Invalid query" (Error 500) message with MS SQL when displaying an issue from a list grouped and sorted by fixed version

Added by Olivier Houdas about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Issues
Target version:
3.1.7
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
3.1.3

Description

Steps:
Prerequisite: this happens only with MS SQL
  1. Filter a list of issues by grouping on the fixed version field, and showing the priority field
  2. Click on the Fixed version field to sort on it in descending order, click on the priority field to also sort on that field
    This should result in a query like this one for example
  3. Click on one bug of the list
    Result: Error 500, Invalid query. In the log, it is indicated that there are duplicated column names in an ORDER BY clause
    Note: the issue also happens on MySQL, but MySQL does not consider duplicated sort columns as an error.

The issue happens in the feature to be able to navigate with arrows to the next or previous bug in the list we came from.
As the Fixed_version field implements a call back with its own sortable columns, this comes into the group_by_sort_order statement, which then brings columns duplicated with the ones coming from the options.

Note that with a MySQL-backed Redmine site, the effect is that the order of the list can be incorrect in the previous/Next arrows on the displayed bug.

See attached patch for a suggested fix.

Files

Download all files
fix_duplicated_order_by_columns.patch (999 Bytes) fix_duplicated_order_by_columns.patch proposed code fix Olivier Houdas, 2016-09-15 15:01
fix_duplicated_order_by_columns_v2.patch (1.19 KB) fix_duplicated_order_by_columns_v2.patch Olivier Houdas, 2016-09-22 14:23
Actions
Copy link

Also available in: Atom PDF