Patch #2482
closedNamed scopes in Issue and ActsAsWatchable plus some view refactoring (logic extraction).
100%
Description
Added named_scope in Issue and ActsAsWatchable replacing custom finder method declarations in model classes and custom find queries in views.
More specifically this patch introduces the following changes:
- Replaces
watched_by
class method in ActsAsWatchable with anamed_scope
of the same name (so no API breaking) - Adds
Issue::recently_updated
,Issue::with_limit
andIssue::on_active_project
which are optional but handy. If they seem reduntant they can be removed and update the views accordingly (see next bullet) - Removes DB logic from partial view
my/blocks/_issueswatched.rhtml
which falls back to new named scopes. It would be even better if this thing was inside the controller (that is the right place) but because of the modularity of my/page (due to the blocks) I didn't touch it.
plus:
- Tests for introduced changes
- Minor documentation for introduced changes
Patch is against trunk r2250.
Note: If you find it useful I could also refactor other parts of redmine, replacing custom finders with named scopes (if possible) and extracting model logic from views. Just let me know, or simply apply this patch :)
Files
Updated by Eric Davis almost 16 years ago
- Assignee set to Eric Davis
I'll take a look at this patch and see about appling.
Note: If you find it useful I could also refactor other parts of redmine, replacing custom finders with named scopes (if possible) and extracting model logic from views. Just let me know, or simply apply this patch :)
I would find that really useful. I've been waiting for 0.8 to be released before I went through refactoring. If you use git, could you branch from my GitHub repository and send me the patches through GitHub? It makes it easy to review and apply them.
Thanks
Updated by Eric Davis almost 16 years ago
- Status changed from New to 7
Updated by Eric Davis over 14 years ago
- Category set to Code cleanup/refactoring
- Status changed from 7 to Closed
- Target version set to 1.0.0 (RC)
- % Done changed from 0 to 100
Committed in r3557