Actions
Defect #24869
closedCircular inclusion detected when including a wiki page with the same name
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
A Circular inclusion is incorrectly identified when including a page internal to a project with the same name from another project. This affects version prior to and including 3.3.2. To recreate:
- Create test-project-1
 - Create wiki page named "IncludedPage" with any contents
 - Create test-project-2
 - Create wiki page named "IncludedPage"; contents include to test-project-1: {{include(test-project-1:IncludedPage)}}
 - Create wiki page named "TestPage"; contents include to local IncludedPage: {{include(IncludedPage)}}
 
In test-project-2/IncludedPage there is no error, however in test-project-2/TestPage the circular inclusion is detected.
Suggest modifying lib/redmine/wiki_formatting/macros.rb to use page.id instead of page.title.
Files
      
      Updated by Michael Esemplare almost 9 years ago
      
    
    - File 0001-Modify-circular-inclusion-test-to-use-page.id-instea.patch added
 
Added patch and recreated on demo.redmine.org
http://demo.redmine.org/projects/test-project-1/wiki
http://demo.redmine.org/projects/test-project-2/wiki/TestPage
      
      Updated by Michael Esemplare almost 9 years ago
      
    
    - File 0002-Modify-circular-inclusion-test-to-use-page.id-instea.patch 0002-Modify-circular-inclusion-test-to-use-page.id-instea.patch added
 
Incorrect patch previously uploaded. Please remove 0001 and use 0002 instead.
      
      Updated by Go MAEDA almost 9 years ago
      
    
    - File deleted (
0001-Modify-circular-inclusion-test-to-use-page.id-instea.patch) 
      
      Updated by Go MAEDA almost 9 years ago
      
    
    - File circular-inclusion-error.png circular-inclusion-error.png added
 - Status changed from New to Confirmed
 - Target version set to 3.3.3
 
Confirmed the problem and the patch works fine as expected.

      
      Updated by Jean-Philippe Lang almost 9 years ago
      
    
    - Status changed from Confirmed to Resolved
 - Assignee set to Jean-Philippe Lang
 - Resolution set to Fixed
 
Committed, thanks.
      
      Updated by Jean-Philippe Lang almost 9 years ago
      
    
    - Subject changed from False Positive: Circular Inclusion Detected for include macro to Circular inclusion detected when including a wiki page with the same name
 - Status changed from Resolved to Closed
 - Target version changed from 3.3.3 to 3.2.6
 
Actions