Actions
Defect #25118
closedThemesTest#test_without_theme_js may fail if third-party theme is installed
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
test/unit/lib/redmine/themes_test.rb may fail if third party theme which has javascripts/theme.js is installed.
1) Failure: ThemesTest#test_without_theme_js [test//integration/lib/redmine/themes_test.rb:43]: Expected exactly 0 elements matching "script[src^="/themes/redminecrm/javascripts/theme.js"]", found 1.. Expected: 0 Actual: 1
This issue can be fixed by the following patch:
Index: test/integration/lib/redmine/themes_test.rb
===================================================================
--- test/integration/lib/redmine/themes_test.rb (revision 16332)
+++ test/integration/lib/redmine/themes_test.rb (working copy)
@@ -37,6 +37,8 @@
end
def test_without_theme_js
+ # simulate a state theme.js does not exists
+ @theme.javascripts.clear
get '/'
assert_response :success
Related issues
Updated by Jean-Philippe Lang almost 8 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks.
Updated by Go MAEDA over 5 years ago
- Related to Patch #31941: ThemesTest may fail if a third-party theme with a favicon is installed added
Actions