Redmine

I have the same problems under v0.7.4
Thanks

It seems to me there are two issues here.

One is that the syntax highlighter doesn't handle a standalone code tag. The line numbers don't mess up if I do:

<pre><code class="php">
...
</code>< /pre>

And the other issue is that php syntax highlighting only seems to work in the repository browser, not in the wiki. In our redmine installation, we are using javascript as a workaround for this, since the syntax is very similar.

Abhi Beckert wrote:

It seems to me there are two issues here.

One is that the syntax highlighter doesn't handle a standalone code tag. The line numbers don't mess up if I do:

[...]

Hmm, this seems to be a design-choice made by the Redmine developers. I'll explain...

• Code within code tags (without a class definition) is handled by Redmine/RedCloth. Here's an example:

<c0de>
<?php
echo "Hello World!";
?>
</c0de>

renders as:

Thus within these tags the content is rendered with a different font-family (monospace) and newlines are ignored. No line-numbering is added nor any highlighting is done.

• To enable highlighting (and to enable line-numbering) the code-tags should be used with a class-definition (which should be the name of a language which is supported by Redmine through the CodeRay-library) and they should be surrounded by pre-tags.

Example:

<Pre><c0de class="ruby">
# The Greeter class
class Greeter
  def initialize(name)
    @name = name.capitalize
  end

  def salute
    puts "Hello #{@name}!" 
  end
end</c0de></Pre>

renders as:

# The Greeter class
class Greeter
  def initialize(name)
    @name = name.capitalize
  end

  def salute
    puts "Hello #{@name}!" 
  end
end

Thus, within code-tags with a supported class-definition, which are surrounded by pre-tags, content is rendered with a different font-family (monospace), newlines are respected, line-numbering is added and highlighting is done.

• code-tags with a (supported) class-definition but without surrounding pre-tags is not supported and will mess-up the output heavily.

Example:

<c0de class="ruby">
# The Greeter class
class Greeter
  def initialize(name)
    @name = name.capitalize
  end

  def salute
    puts "Hello #{@name}!" 
  end
end
</c0de>

will render as:

Thus, within code-tags with a supported class-definition, which are not surrounded by pre-tags, content is rendered with a different font-family (monospace), highlighting is done but newlines are not respected while line-numbering is added.

Abhi Beckert wrote:

And the other issue is that php syntax highlighting only seems to work in the repository browser, not in the wiki. In our redmine installation, we are using javascript as a workaround for this, since the syntax is very similar.

Here you have the "real" issue. Currently PHP syntax-highlighting does not work in Redmine at all except in the Repository browser. IIRC this was made possible due to a custom change by the Redmine Developers.

An example of the issue:

<Pre><c0de class="php">
function add_ending_slash($path){

    $slash_type = (strpos($path, '\\')===0) ? 'win' : 'unix'; 

    $last_char = substr($path, strlen($path)-1, 1);

    if ($last_char != '/' and $last_char != '\\') {
        // no slash:
        $path .= ($slash_type == 'win') ? '\\' : '/';
    }

    return $path;
}
</c0de></Pre>

will render without highlighting as:

function add_ending_slash($path){

    $slash_type = (strpos($path, '\\')===0) ? 'win' : 'unix'; 

    $last_char = substr($path, strlen($path)-1, 1);

    if ($last_char != '/' and $last_char != '\\') {
        // no slash:
        $path .= ($slash_type == 'win') ? '\\' : '/';
    }

    return $path;
}

The recent upgrade to CodeRay 0.9 RC2 solved this issue temporarily. The upgrade is reverted due to several other reasons (see issue #3359 and it's relatives).

Most likely this issue will still be solved after completion of #3359.