Defect #26730
closedContext Menu is broken on 3.4.2
0%
Description
On 3.3.0, I found these occurrences of contextMenuInit
redmine-3.3.0/public/javascripts/context_menu.js:function contextMenuInit(url) { redmine-3.3.0/test/functional/versions_controller_test.rb: assert_select "script", :text => Regexp.new(Regexp.escape("contextMenuInit('/issues/context_menu')")) redmine-3.3.0/app/helpers/application_helper.rb: javascript_tag "contextMenuInit('#{ url_for(url) }')"
rather than on 3.4.2
redmine-3.4.2/public/javascripts/context_menu.js:function contextMenuInit(url) {
A diff shows
@ -1154,7 +1297,7 @@
end
end
- def context_menu(url)
+ def context_menu
unless @context_menu_included
content_for :header_tags do
javascript_include_tag('context_menu') +
@@ -1167,7 +1310,7 @@
end
@context_menu_included = true
end
- javascript_tag "contextMenuInit('#{ url_for(url) }')"
+ nil
end
def calendar_for(field_id)
Updated by Toshi MARUYAMA over 7 years ago
- Description updated (diff)
- Status changed from New to Needs feedback
- Priority changed from High to Normal
Please explain more details.
Updated by fabrice salvaire over 7 years ago
Right click on issues doesn't work any more on my Redmine 4.3.2 instance. And any event is attached on the ul/il elments.
Up to now, I only found the contextMenuInit function is no longer called. Is it dead code ?
Updated by fabrice salvaire over 7 years ago
It doesn't solve the issue.
I tested on Firefox and Chrome, there is any click and contextmenu event attached on the html element.
I added an explicit call to contextMenuInit at the end of context_menu.js, it attaches the event but it not enough to fix the issue.
Updated by fabrice salvaire over 7 years ago
Only this one http://github.com/bluezio/redmine_wiki_backlinks
And a custom theme
Updated by Toshi MARUYAMA over 7 years ago
What happens without your custom theme or plugin?
Updated by fabrice salvaire over 7 years ago
Found issue, I did a mistake when I upgraded since I believed public was empty in source.
Must be rejected.
Updated by Toshi MARUYAMA over 7 years ago
- Status changed from Needs feedback to Closed
- Resolution set to Invalid