Actions
Defect #26730
closedContext Menu is broken on 3.4.2
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Invalid
Affected version:
Description
On 3.3.0, I found these occurrences of contextMenuInit
redmine-3.3.0/public/javascripts/context_menu.js:function contextMenuInit(url) { redmine-3.3.0/test/functional/versions_controller_test.rb: assert_select "script", :text => Regexp.new(Regexp.escape("contextMenuInit('/issues/context_menu')")) redmine-3.3.0/app/helpers/application_helper.rb: javascript_tag "contextMenuInit('#{ url_for(url) }')"
rather than on 3.4.2
redmine-3.4.2/public/javascripts/context_menu.js:function contextMenuInit(url) {
A diff shows
@ -1154,7 +1297,7 @@
end
end
- def context_menu(url)
+ def context_menu
unless @context_menu_included
content_for :header_tags do
javascript_include_tag('context_menu') +
@@ -1167,7 +1310,7 @@
end
@context_menu_included = true
end
- javascript_tag "contextMenuInit('#{ url_for(url) }')"
+ nil
end
def calendar_for(field_id)
Actions