Project

General

Profile

Actions
Copy link

Defect #2695

closed

Side by side revision comparison seems broken

Added by Brad Beattie almost 16 years ago. Updated almost 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2009-02-07
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Not sure if this is just my installation, or if everyone's experiencing this.

Inline view works fine, but switching to side-by-side mode causes NoMethodError (undefined method `join' for "appviewsschedules_calendar.html.erb":String).

Processing RepositoriesController#revision (for ---.---.---.--- at 2009-02-07 11:15:11) [GET]
  Session ID: de7d739fcd289c83517b86b215ee9774
  Parameters: {"rev"=>"11", "action"=>"revision", "id"=>"23", "controller"=>"repositories"}
Rendering template within layouts/base
Rendering repositories/revision
Completed in 0.02206 (45 reqs/sec) | Rendering: 0.01405 (63%) | DB: 0.00278 (12%) | 200 OK [https://-----------------------------/projects/23/repository/revisions/11]

Processing RepositoriesController#diff (for ---.---.---.--- at 2009-02-07 11:15:13) [GET]
  Session ID: de7d739fcd289c83517b86b215ee9774
  Parameters: {"rev"=>"11", "action"=>"diff", "id"=>"focus-plugin", "controller"=>"repositories", "path"=>["app", "views", "schedules", "_calendar.html.erb"]}
Rendering template within layouts/base
Rendering repositories/diff
Completed in 0.03615 (27 reqs/sec) | Rendering: 0.01066 (29%) | DB: 0.00081 (2%) | 200 OK [https://-----------------------------/projects/focus-plugin/repository/revisions/11/diff/app/views/schedules/_calendar.html.erb]

Processing RepositoriesController#diff (for ---.---.---.--- at 2009-02-07 11:15:15) [GET]
  Session ID: de7d739fcd289c83517b86b215ee9774
  Parameters: {"rev"=>"11", "action"=>"diff", "type"=>"sbs", "id"=>"focus-plugin", "controller"=>"repositories", "path"=>"appviewsschedules_calendar.html.erb"}

NoMethodError (undefined method `join' for "appviewsschedules_calendar.html.erb":String):
    /app/controllers/repositories_controller.rb:208:in `find_repository'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/callbacks.rb:173:in `send'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/callbacks.rb:173:in `evaluate_method'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/callbacks.rb:161:in `call'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:191:in `call'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:591:in `run_before_filters'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:577:in `call_filters'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
    /usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
    /usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
    /usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/query_cache.rb:8:in `cache'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `send'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `process_without_filters'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/session_management.rb:130:in `process'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:389:in `process'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:149:in `handle_request'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:107:in `dispatch'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `synchronize'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `dispatch'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
    /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:35:in `dispatch'
    /usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:112:in `handle_dispatch'
    /usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:78:in `service'
    /usr/lib/ruby/1.8/webrick/httpserver.rb:104:in `service'
    /usr/lib/ruby/1.8/webrick/httpserver.rb:65:in `run'
    /usr/lib/ruby/1.8/webrick/server.rb:173:in `start_thread'
    /usr/lib/ruby/1.8/webrick/server.rb:162:in `start'
    /usr/lib/ruby/1.8/webrick/server.rb:162:in `start_thread'
    /usr/lib/ruby/1.8/webrick/server.rb:95:in `start'
    /usr/lib/ruby/1.8/webrick/server.rb:92:in `each'
    /usr/lib/ruby/1.8/webrick/server.rb:92:in `start'
    /usr/lib/ruby/1.8/webrick/server.rb:23:in `start'
    /usr/lib/ruby/1.8/webrick/server.rb:82:in `start'
    /usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:62:in `dispatch'
    /usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/commands/servers/webrick.rb:66
    /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:510:in `require'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:355:in `new_constants_in'
    /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:510:in `require'
    /usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/commands/server.rb:39
    /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    script/server:3

Rendering /home/redmine/redmine/public/500.html (500 Internal Server Error)
Actions
Copy link
 #1

Updated by Jean-Philippe Lang almost 16 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

You're right. But it's not specific to side by side display, it happens when changing display type (inline -> side by side or side by side -> inline).
Yet another thing that was broken by URL changes in r2317.

Fixed in r2399.

Actions
Copy link

Also available in: Atom PDF