Redmine

Nice improvement, setting target version to 4.1.0.

The test RepositoriesGitControllerTest#test_diff_should_show_filenames fails on my environment. Would you look into this?

$ ruby test/functional/repositories_git_controller_test.rb
Run options: --seed 19867

# Running:

.......F

Failure:
RepositoriesGitControllerTest#test_diff_should_show_filenames [test/functional/repositories_git_controller_test.rb:432]:
<sources/watchers_controller.rb> expected but was
<copied_README>..
Expected 0 to be >= 1.

/path/to/gems/ruby/2.3.0/gems/railties-5.1.4/lib/rails/test_unit/reporter.rb:70:in `method': undefined method `test_diff_should_show_filenames' for class `Minitest::Result' (NameError)
    from /path/to/gems/ruby/2.3.0/gems/railties-5.1.4/lib/rails/test_unit/reporter.rb:70:in `format_rerun_snippet'

Rails version             5.1.4
Ruby version              2.3.3-p222 (x86_64-darwin16)
RubyGems version          2.6.10
Rack version              2.0.4

Thank you for taking a look. Unfortunately, I didn't set up the test repositories. That's why I didn't catch the test failure.

Attached you may find an updated patch. Now all tests seem to pass fine.

Gregor Schmidt wrote:

Attached you may find an updated patch. Now all tests seem to pass fine.

Thanks, I confirmed that it passes all tests.

Committed. Thank you for your contribution.