Defect #28668: redmine_plugin_controller generates camelcase filename - Redmine

Actions

Copy link

Defect #28668

closed

redmine_plugin_controller generates camelcase filename

Added by Toru Takahashi almost 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Plugin API

Target version:

4.0.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

3.4.5

Description

redmine_plugin_controller generates not snake case file name but camel case file name when specifying controller name as camel case.

For example:

$ bundle exec rails generate redmine_plugin_controller hello_message FooBars
      create  plugins/hello_message/app/controllers/FooBars_controller.rb
      create  plugins/hello_message/app/helpers/FooBars_helper.rb
      create  plugins/hello_message/test/functional/FooBars_controller_test.rb

This causes

On the other hand, redmine_plugin_model generates snake case file name when specifying model name as camel case.

$ bundle exec rails generate redmine_plugin_model hello_message FooBar
      create  plugins/hello_message/app/models/foo_bar.rb
      create  plugins/hello_message/test/unit/foo_bar_test.rb
      create  plugins/hello_message/db/migrate/004_create_foo_bars.rb

Ruby on Rails' rails generate controller FooBars command generates snake case file name: 'foo_bars_controller.rb', too.

Environment is as follows

Environment:
  Redmine version                3.4.5.stable.17297
  Ruby version                   2.4.3-p205 (2017-12-14) [x86_64-linux]
  Rails version                  4.2.8
  Environment                    production
  Database adapter               SQLite

trunk has same behavior.

I expect to generate controller file with snake case name even if controller name is specified by camel case, like model file name.

Files

redmine_plugin_controller_generates_snakecase_filename.diff (1.28 KB) redmine_plugin_controller_generates_snakecase_filename.diff

patch for redmine_plugin_controller_generator.rb to generate snake case file name

Toru Takahashi, 2018-05-01 02:57

Actions

Copy link

Updated by Toru Takahashi almost 6 years ago

File redmine_plugin_controller_generates_snakecase_filename.diff redmine_plugin_controller_generates_snakecase_filename.diff added

lib/generators/redmine_plugin_controller/redmine_plugin_controller_generator.rb
uses the argument of controller name to generate file name without modification to snake case.
For example,
```
template 'controller.rb.erb', "#{plugin_path}/app/controllers/#{controller}_controller.rb"
```
lib/generators/redmine_plugin_model/redmine_plugin_model_generator.rb
uses the argument of model name to generate file name with modification to snake case.
For example,
```
template 'model.rb.erb', "#{plugin_path}/app/models/#{model.underscore}.rb"
```

I attached a fix patch for redmine_plugin_controller_generator.rb to generate file name with snake case controller name like redmine_plugin_model_generator.rb.
This patch is generate under svn r17297 (3.4-stable branch).

Actions

Copy link