Actions
Defect #28920
closed
Redmine::VERSION::revision should take subversion_command setting into account
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
The revision number may not be shown on admin_info page because the execution of the svn command fails in some cases.
Redmine::VERSION::revision method should take scm_subversion_command setting into account.
Index: lib/redmine/version.rb
===================================================================
--- lib/redmine/version.rb (revision 17354)
+++ lib/redmine/version.rb (working copy)
@@ -17,7 +17,7 @@
if File.directory?(File.join(Rails.root, '.svn'))
begin
path = Redmine::Scm::Adapters::AbstractAdapter.shell_quote(Rails.root.to_s)
- if `svn info --xml #{path}` =~ /revision="(\d+)"/
+ if `#{Redmine::Scm::Adapters::SubversionAdapter.client_command} info --xml #{path}` =~ /revision="(\d+)"/
return $1.to_i
end
rescue
Related issues
Updated by Go MAEDA over 6 years ago
- Related to Feature #7517: Configurable path of executable for scm adapters added
Updated by Go MAEDA over 6 years ago
- Subject changed from Redmine::VERSION::revision method may fail due to hardcoded svn command name to Redmine::VERSION::revision should take subversion_command_setting into account
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from 4.1.0 to 4.0.0
- Resolution set to Fixed
Committed. The patch was provided by Yuichi Harada. Thank you for the contribution.
Updated by Go MAEDA over 6 years ago
- Subject changed from Redmine::VERSION::revision should take subversion_command_setting into account to Redmine::VERSION::revision should take subversion_command setting into account
Updated by Go MAEDA about 5 years ago
- Related to Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks added
Actions