Actions
Patch #31030
closed
Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
Start date:
Due date:
% Done:
0%
Estimated time:
Description
The exception is :
lib/redmine/plugin.rb:141:in `find': Redmine::PluginNotFound (Redmine::PluginNotFound)
It would be better if it is :
lib/redmine/plugin.rb:273:in `rescue in requires_redmine_plugin': redmine_smile_enhancements plugin requires plugin redmine_smile_base (Redmine::PluginNotFound)
Files
Updated by Jérôme BATAILLE almost 6 years ago
- File RM_dependant_plugin_missing_exception_svn.diff RM_dependant_plugin_missing_exception_svn.diff added
Here is the patch.
Updated by Go MAEDA almost 6 years ago
- Category changed from Core Plugins to Plugin API
- Target version set to Candidate for next minor release
I think it should catch only PluginNotFound exception.
diff --git a/lib/redmine/plugin.rb b/lib/redmine/plugin.rb
index ec575d17a..16e266da1 100644
--- a/lib/redmine/plugin.rb
+++ b/lib/redmine/plugin.rb
@@ -270,7 +270,11 @@ module Redmine
arg = { :version_or_higher => arg } unless arg.is_a?(Hash)
arg.assert_valid_keys(:version, :version_or_higher)
- plugin = Plugin.find(plugin_name)
+ begin
+ plugin = Plugin.find(plugin_name)
+ rescue PluginNotFound
+ raise PluginRequirementError.new("#{id} plugin requires the #{plugin_name} plugin")
+ end
current = plugin.version.split('.').collect(&:to_i)
arg.each do |k, v|
Updated by Go MAEDA almost 6 years ago
- Target version changed from Candidate for next minor release to 4.0.3
Setting the target version to 4.0.3.
Updated by Go MAEDA almost 6 years ago
- Subject changed from Missing dependant plugin : give missing plugin name in exception to Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
Updated by Jean-Philippe Lang almost 6 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks.
Actions