Project

General

Profile

Actions

Patch #31343

closed

Visually distinguishable style for code tag

Added by Go MAEDA over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I propose to make the style for code tag more distinguishable.

Currently, the font-family property is the only property which is set for code tag. So, it is a bit difficult to distinguish text enclosed in code tag.

It will be easily distinguishable if we set background color for them. It is so common. You can see examples on many sites such as GitHub and https://bugs.ruby-lang.org/.

[Before]

[After]


Files

code-style-before@2x.png (67.1 KB) code-style-before@2x.png Go MAEDA, 2019-05-11 12:04
code-style-after@2x.png (68.8 KB) code-style-after@2x.png Go MAEDA, 2019-05-11 12:04
style-for-code.diff (474 Bytes) style-for-code.diff Go MAEDA, 2019-05-11 12:04
style-for-code-v2.diff (483 Bytes) style-for-code-v2.diff Go MAEDA, 2019-05-13 16:34
style-for-code-v3.diff (498 Bytes) style-for-code-v3.diff Go MAEDA, 2019-05-15 10:13

Related issues

Related to Redmine - Feature #12036: Allow backtip for inline code with inline block styleClosed

Actions
Actions #1

Updated by Go MAEDA over 5 years ago

  • Subject changed from Visually distinguishable code tag style to Visually distinguishable style for code tag
  • Target version set to 4.1.0

Setting the target version to 4.1.0.

Actions #3

Updated by Go MAEDA over 5 years ago

Update the patch.

  • Changed the color to rgba(62, 91, 118, 0.08). The previous color rgba(0, 102, 187, 0.05) looks like selected text in some operating system
  • Fixed wrong selector
  • Fixed that the style is not applied in long text custom fields
Actions #4

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Actions #5

Updated by Go MAEDA about 5 years ago

  • Related to Feature #12036: Allow backtip for inline code with inline block style added
Actions

Also available in: Atom PDF