Defect #32829
closed
HTML entity is used in CSS string
0%
Description
Ordering handles (green arrows ↕) at some administrative pages contains HTML entity instead of inivisible character of non-breaking space:
Affected pages¶
- /roles
- /trackers
- /issue_statuses
- /enumerations
- /custom_fields
Configuration¶
- MySQL 5.5.44
- ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]
- Rails 5.2.4.1
- Redmine 4.1.0
- Plugins:
- Redmine CRM plugin 4.2.5
- Custom JS and CSS plugin 0.0.1
- Redmine Open Search plugin 0.1.0
- Google Chrome 79
How to fix¶
Edit public/stylesheets/application.css:
.icon-only::after {
content: " ";
}
replace with
- non-breaking space
or \a0
Files
Related issues
Updated by Alexander Sapozhnikov over 4 years ago
- File application-css.patch application-css.patch added
--- application.css~ 2019-12-20 17:19:46.000000000 +0500
+++ application.css 2020-01-17 05:28:57.819227647 +0500
@@ -1458,3 +1458,3 @@
.icon-only::after {
- content: " ";
+ content: "\a0";
}
Updated by Go MAEDA about 4 years ago
- File roles-no-problem@2x.png roles-no-problem@2x.png added
I cannot reproduce the problem. Could you test again without third-party plugins and a theme?
Updated by Alexander Sapozhnikov about 4 years ago
- File issue-32829-hidden.png issue-32829-hidden.png added
I’ve checked with Alternate and Classic themes — there are no visible characters
But anyway HTML entity should be replaced with allowed character or escape sequence.
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Most characters can be represented literally. All characters can also be represented with their respective Unicode code points in hexadecimal, in which case they are preceded by a backslash (
\). For example,\22represents a double quote,\27a single quote ('), and\A9the copyright symbol (©).
Note: HTML entities (such as
or—) cannot be used in a CSS<string>.
See also:
Updated by Go MAEDA about 4 years ago
- Target version set to 4.1.1
Alexander Sapozhnikov wrote:
But anyway HTML entity should be replaced with allowed character or escape sequence.
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Most characters can be represented literally. All characters can also be represented with their respective Unicode code points in hexadecimal, in which case they are preceded by a backslash (
\). For example,\22represents a double quote,\27a single quote ('), and\A9the copyright symbol (©).Note: HTML entities (such as
or—) cannot be used in a CSS<string>.
Thank you for giving me the information. I didn't know that.
Setting the target version to 4.1.1.
Updated by Go MAEDA about 4 years ago
- Target version changed from 4.1.1 to 4.0.7
- Affected version changed from 4.1.0 to 3.3.0
The change has been made in r15271 (Redmine 3.3.0). Updating the target version to 4.0.7.
Updated by Go MAEDA about 4 years ago
- Related to Patch #21805: Improve accessibility for icon-only links added
Updated by Go MAEDA about 4 years ago
- Subject changed from HTML entities instead of non-breaking space near ordering handles to HTML entity is used in CSS string
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for posting the patch.