Project

General

Profile

Actions
Copy link

Defect #32858

closed

Exporting issue as PDF fails when the issue has private journal

Added by Kouhei Sutou almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
PDF export
Target version:
4.1.1
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If an issue that has one or more private journals, PDF export of the issue is failed with the following backtrace:

ActionView::Template::Error (can't modify frozen String):
    1: <%= raw issue_to_pdf(@issue, :journals => @journals) %>

lib/redmine/export/pdf/issues_pdf_helper.rb:215:in `block in issue_to_pdf'
lib/redmine/export/pdf/issues_pdf_helper.rb:212:in `each'
lib/redmine/export/pdf/issues_pdf_helper.rb:212:in `issue_to_pdf'
app/views/issues/show.pdf.erb:1:in `_app_views_issues_show_pdf_erb___2781995059460618483_69922049768460'
lib/redmine/sudo_mode.rb:65:in `sudo_mode'

I attach a patch to fix this.

Files

fix-issue-with-private-jorunal-pdf-export.diff (1.67 KB) fix-issue-with-private-jorunal-pdf-export.diff Kouhei Sutou, 2020-01-24 02:38
Actions
Copy link
 #1

Updated by Go MAEDA almost 5 years ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
  • Target version set to 4.1.1

I have confirmed this issue and it can be fixed with the attached patch.

Setting the target version to 4.1.1.

Actions
Copy link
 #2

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Failed to export issue as PDF when the issue has private journal to Exporting issue as PDF fails when the issue has private journal
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for catching and fixing the issue.

Actions
Copy link

Also available in: Atom PDF