Project

General

Profile

Actions

Defect #33357

closed

rendering extra "--" footer of git patch attachment

Added by Toshi MARUYAMA over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Attachments
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

From #17809.

For example #4511 0002-Use-Principal-to-get-users-and-groups-for-watchers-i.patch.

#17809#note-5 has solution.


Files

git-diff.png (120 KB) git-diff.png Toshi MARUYAMA, 2020-04-26 17:01
Actions #1

Updated by Toshi MARUYAMA over 4 years ago

  • Subject changed from rendering extra "---" header and "--" footer of git patch attachment to rendering extra "--" footer of git patch attachment

Fixed title.

Actions #2

Updated by Toshi MARUYAMA over 4 years ago

#17809#note-5 is not solution in this case.

# test
# test
# next line has white space after '-'
- 
-
# test
# test
# test
# test
diff --git a/test.rb b/test.rb
--- a/test.rb
+++ b/test.rb
@@ -3,9 +3,6 @@

 # test
 # test
-# next line has white space after '-'
-- 
--
 # test
 # test
 # test
Actions #3

Updated by Toshi MARUYAMA over 4 years ago

  • Target version set to 4.2.0
  • Resolution set to Fixed

Fixed by r19752.

Actions #4

Updated by Go MAEDA almost 4 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF