Patch #33367: Use more efficient "exists?" instead of "first" in tests when checking the existence of rows - Redmine

Patch #33367

Added by Go MAEDA 3 months ago. Updated 3 months ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

% Done:

Category:

Code cleanup/refactoring

Target version:

Description

When you check if any row exists, using exists? that does not return ActiveRecord objects is more efficient than using first.

The attached patch replaces first with exists?.

use-exists-instead-of-first.patch (6.67 KB) Go MAEDA, 2020-04-29 11:03

Use more efficient "exists?" instead of "first" in tests when checking the existence of rows (#33367).

Patch by Go MAEDA.

Subject changed from Use more efficient "exists?" instead of "first” in tests when checking the existence of rows to Use more efficient "exists?" instead of "first" in tests when checking the existence of rows

Setting the target version to 4.2.0.

Committed the patch.

Also available in: Atom PDF