Defect #33374

hook call "view_layouts_base_body_bottom" Inserts content below the viewport

Added by Oliver Köhler almost 3 years ago. Updated almost 3 years ago.

Status:ConfirmedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Plugin API
Target version:-
Resolution: Affected version:4.1.1

Description

The content added via the "view_layouts_base_body_bottom" Hook is generated outside of any wrapper object.
With r18427 the size of the wrapper object is set to 100% of the viewport height.
As "view_layouts_base_body_bottom" places content outside of that wrapper, that content is now displayed outside of the viewport.
A possible fix could be placing the 

<%= call_hook :view_layouts_base_body_bottom %>

line within the wrapper object like this
  <div id="footer">
      Powered by <%= link_to Redmine::Info.app_name, Redmine::Info.url %> &copy; 2006-2020 Jean-Philippe Lang
  </div>
  <%= call_hook :view_layouts_base_body_bottom %>
</div>

History

#1 Updated by Oliver Köhler almost 3 years ago

Forgot to mention the file for the possible fix:
app/views/layouts/base.html.erb

#2 Updated by Go MAEDA almost 3 years ago

  • Status changed from New to Confirmed

I have confirmed that a user has to scroll down to see the content inserted with view_layouts_base_body_bottom as reported by Oliver Köhler.

But I am not sure whether moving the position of view_layouts_base_body_bottom is the best solution because the change makes an inconsistency. The inconsistency is that the view_layouts_base_top is currently placed right after the <body>, but the view_layouts_base_bottom will no longer be placed right before the </body> after applying the fix.

Maybe fixing this by somehow updating the CSS is better?

Also available in: Atom PDF